You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/01 16:57:53 UTC

[GitHub] [solr] HoustonPutman opened a new pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

HoustonPutman opened a new pull request #281:
URL: https://github.com/apache/solr/pull/281


   https://issues.apache.org/jira/browse/SOLR-11752
   
   Built off the patch found in the above JIRA.
   
   This is enabled by default but can be removed by setting `SOLR_GZIP_ENABLED=false`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] msporleder commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
msporleder commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910688594


   thank you for reviving this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman merged pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #281:
URL: https://github.com/apache/solr/pull/281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910502435


   Would this let me  post  a  gzipped CSV  file directly to Solr?     unzipping a giant CSV,  then  sending it  over, was  always  painful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910937837


   ah; of course.  I didn't notice it in the IntelliJ PR view but I see it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910714340


   > Question: where is the Jetty gzip module defined? I expected to see a file or dir named similarly.
   
   Well it's defined, I believe, in the `solr/server/modules/gzip.mod` file, which points to the `solr/server/etc/jetty-gzip.xml` config file. This loads in the `GzipHandler` class which is included in `jetty-server.jar`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910657354


   +1 LGTM though I rely on your testing as I did none.
   Question: where is the Jetty gzip module defined?  I expected to see a file or dir named similarly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910473594


   Oh the only jetty-gzip setting I changed was defaulting the allowed methods to `GET,POST`, since POST is a popular way of querying with large URL params.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #281:
URL: https://github.com/apache/solr/pull/281#issuecomment-910537372


   > Would this let me post a gzipped CSV file directly to Solr? unzipping a giant CSV, then sending it over, was always painful.
   
   I don't believe this affects data being sent to solr, only data being compressed when being sent in a response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org