You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joe Brockmeier <jz...@zonker.net> on 2012/09/03 00:21:16 UTC
Re: Review Request: Adding empty shell for AWS guide in /docs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6776/#review10986
-----------------------------------------------------------
This looks OK - but is there any reason to create the files first without content? This doesn't hurt anything to create an empty shell - but I don't think it actually is necessary.
- Joe Brockmeier
On Aug. 26, 2012, 6:39 p.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6776/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2012, 6:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Created two docbook empty shells for EC2 and S3 user guide
>
>
> Diffs
> -----
>
> docs/en-US/aws-ec2-user-guide.xml PRE-CREATION
> docs/en-US/aws-s3-user-guide.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6776/diff/
>
>
> Testing
> -------
>
> No testing done so far
>
>
> Thanks,
>
> Sebastien Goasguen
>
>
Re: Review Request: Adding empty shell for AWS guide in /docs
Posted by Sebastien Goasguen <ru...@gmail.com>.
> On Sept. 2, 2012, 10:21 p.m., Joe Brockmeier wrote:
> > This looks OK - but is there any reason to create the files first without content? This doesn't hurt anything to create an empty shell - but I don't think it actually is necessary.
I thought that's what you wanted. And since I saw empty files in there, I went ahead. I will commit the content and drop this review.
- Sebastien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6776/#review10986
-----------------------------------------------------------
On Aug. 26, 2012, 6:39 p.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6776/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2012, 6:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Created two docbook empty shells for EC2 and S3 user guide
>
>
> Diffs
> -----
>
> docs/en-US/aws-ec2-user-guide.xml PRE-CREATION
> docs/en-US/aws-s3-user-guide.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6776/diff/
>
>
> Testing
> -------
>
> No testing done so far
>
>
> Thanks,
>
> Sebastien Goasguen
>
>