[jira] [Commented] (KAFKA-268) Add another reconnection condition to the syncProducer: the time elapsed since last connection

["Jun Rao (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206955#comment-13206955 ] 

Jun Rao commented on KAFKA-268:
-------------------------------

Some comments:
1. SyncProducerConfigShared: change reconnectTimeInterval to reconnectTimeIntervalMs and reconnect.timeInterval to reconnect.time.interval.ms, to be consistent with existing naming convention.
2. There is no real change to ByteBufferMessageSet and Utils. Please revert them.
3. The default value of reconnectTimeInterval is too small. Let's set it to 10 minutes. Also, we probably need a way to turn off time-based reconnect. How about using a negative value to indicate that? Let's also add a comment in the code to document that.
                
> Add  another reconnection condition to the syncProducer:  the time elapsed since last connection
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-268
>                 URL: https://issues.apache.org/jira/browse/KAFKA-268
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.7
>            Reporter: Yang Ye
>            Priority: Minor
>         Attachments: kafka-reconnect-time.patch
>
>
> Add  another reconnection condition to the syncProducer:  the time elapsed since last connection. If it's larger than the pre-specified threshold, close the connection and reopen it. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira