You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/29 06:21:38 UTC
[GitHub] [incubator-pinot] adriancole opened a new issue #5944: Move to natural pom versions
adriancole opened a new issue #5944:
URL: https://github.com/apache/incubator-pinot/issues/5944
Currently, `<version>${revision}${sha1}</version>` is coded into maven pom files, rendering tools such as jitpack helpless. It would be nice to have normal versions in these files so we have the same chances to use pinot as other java projects. This is particularly important as SNAPSHOT versions are not deployed and docker tags are ad-hoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5944: Move to natural pom versions
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5944:
URL: https://github.com/apache/incubator-pinot/issues/5944#issuecomment-683248120
The purpose of having revision and sha1 is to have the ability to specify the internal published version of Pinot. By default the revision value is the next release version (like `0.5.0`) and the sha1 value is `-SNAPSHOT`. In LinkedIn, we leverage this to change the version to an internal release (like `0.5.0-dev-12345`) and then publish the release to internal artifactory.
I actually have a PR which moves to natural pom versions: https://github.com/apache/incubator-pinot/pull/5840 but the logic is mixed with migrating the publication. I can split that out to a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5944: Move to natural pom versions
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5944:
URL: https://github.com/apache/incubator-pinot/issues/5944#issuecomment-683249249
Just split that logic out of the previous PR:
https://github.com/apache/incubator-pinot/pull/5945
Could @kishoreg @adriancole take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on issue #5944: Move to natural pom versions
Posted by GitBox <gi...@apache.org>.
kishoreg commented on issue #5944:
URL: https://github.com/apache/incubator-pinot/issues/5944#issuecomment-683245902
+100 for this. @jackjlli can you please explain why this sha was added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org