You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2019/07/09 01:41:08 UTC
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13819
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
This patches fixes a formatting string to use "{0}" rather than "{}"
as Python 2.6 doesn't support "{}"
Testing done:
- Ran the test on Centos6 platform with Python 2.6
Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
---
M tests/custom_cluster/test_session_expiration.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/13819/1
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 17:53:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
This patches fixes a formatting string to use "{0}" rather than "{}"
as Python 2.6 doesn't support "{}"
Testing done:
- Ran the test on Centos6 platform with Python 2.6
Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Reviewed-on: http://gerrit.cloudera.org:8080/13819
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_session_expiration.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4590/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 17:53:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 23:36:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
Patch Set 1: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 17:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13819 )
Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3842/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a914a9ca881181d47bee68641b9c7affbfc0d54
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 02:23:12 +0000
Gerrit-HasComments: No