You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/06 18:57:00 UTC
[jira] [Commented] (FLINK-7310) always use HybridMemorySegment
[ https://issues.apache.org/jira/browse/FLINK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195032#comment-16195032 ]
ASF GitHub Bot commented on FLINK-7310:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4445
Agree with @KurtYoung.
Merging this...
> always use HybridMemorySegment
> ------------------------------
>
> Key: FLINK-7310
> URL: https://issues.apache.org/jira/browse/FLINK-7310
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> For future changes to the network buffers (sending our own off-heap buffers through to netty), we cannot use {{HeapMemorySegment}} anymore and need to rely on {{HybridMemorySegment}} instead.
> We should thus drop any code that loads the {{HeapMemorySegment}} (it is still available if needed) in favour of the {{HybridMemorySegment}} which is able to work on both heap and off-heap memory.
> FYI: For the performance penalty of this change compared to using {{HeapMemorySegment}} alone, see this interesting blob article (from 2015):
> https://flink.apache.org/news/2015/09/16/off-heap-memory.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)