You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/02/15 02:03:19 UTC
[GitHub] [yunikorn-k8shim] 0yukali0 commented on a diff in pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
0yukali0 commented on code in PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#discussion_r1106571609
##########
deployments/scheduler/plugin.yaml:
##########
@@ -96,8 +97,6 @@ spec:
cpu: 4
memory: 2Gi
volumeMounts:
- - mountPath: /etc/kubernetes
- name: scheduler-config
- mountPath: /etc/yunikorn
name: quotamanager-config
Review Comment:
Hi @wilfred-s , you are right and I will remove this in next commit.
After I removed the quatamanager-config, latest yunikorn will use the default configuration here.
<img width="547" alt="image" src="https://user-images.githubusercontent.com/45888688/218907959-7dd7f59a-dad7-4cfd-bff8-91d915d855a2.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org