You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/06/18 05:59:05 UTC
[GitHub] [incubator-heron] nicknezis opened a new pull request #3541: Embedded Trykker font
nicknezis opened a new pull request #3541:
URL: https://github.com/apache/incubator-heron/pull/3541
Fixes #3540 by embedding the Trykker fonts as directed on this [Google webfonts helper app.](https://google-webfonts-helper.herokuapp.com/fonts/trykker?subsets=latin,latin-ext)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3541: Embedded Trykker font
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3541:
URL: https://github.com/apache/incubator-heron/pull/3541#issuecomment-645796420
There is also an option to support only Modern browsers:
```
/* trykker-regular - latin-ext_latin */
@font-face {
font-family: 'Trykker';
font-style: normal;
font-weight: 400;
src: local('Trykker Regular'), local('Trykker-Regular'),
url('../fonts/trykker-v8-latin-ext_latin-regular.woff2') format('woff2'), /* Chrome 26+, Opera 23+, Firefox 39+ */
url('../fonts/trykker-v8-latin-ext_latin-regular.woff') format('woff'); /* Chrome 6+, Firefox 3.6+, IE 9+, Safari 5.1+ */
}
```
I opted for the more generic default:
```
@font-face {
font-family: 'Trykker';
font-style: normal;
font-weight: 400;
src: url('../fonts/trykker-v8-latin-ext_latin-regular.eot'); /* IE9 Compat Modes */
src: local('Trykker Regular'), local('Trykker-Regular'),
url('../fonts/trykker-v8-latin-ext_latin-regular.eot?#iefix') format('embedded-opentype'), /* IE6-IE8 */
url('../fonts/trykker-v8-latin-ext_latin-regular.woff2') format('woff2'), /* Super Modern Browsers */
url('../fonts/trykker-v8-latin-ext_latin-regular.woff') format('woff'), /* Modern Browsers */
url('../fonts/trykker-v8-latin-ext_latin-regular.ttf') format('truetype'), /* Safari, Android, iOS */
url('../fonts/trykker-v8-latin-ext_latin-regular.svg#Trykker') format('svg'); /* Legacy iOS */
}
```
This adds more font formats to the distribution which slightly increases the size, but it might better support older browsers. I'm happy to change the logic to only support newer browsers if you think that would be best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 merged pull request #3541: Embedded Trykker font
Posted by GitBox <gi...@apache.org>.
joshfischer1108 merged pull request #3541:
URL: https://github.com/apache/incubator-heron/pull/3541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org