You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by danielruss <gi...@git.apache.org> on 2016/12/21 21:10:32 UTC
[GitHub] opennlp pull request #14: Refactor data indexer
GitHub user danielruss opened a pull request:
https://github.com/apache/opennlp/pull/14
Refactor data indexer
Added a patch that changes multiple items (Sorry That I did not fix 1 item at a time-I am a scientist not a software engineer):
1.) Added method to EventTrainer \u2013 train(DataIndexer indexer) \u2013Then I added the method to AbstractEventTrainer. No other code needed to be changed.
2.) Created a new class \u2013 PluggableParmeters: Only AbstractTrainers had access to getXXXParam(Value,Default). So I pulled out this functionality into a separate class. Now both AbstractTrainers and AbstractDataIndexers can hold parameters.
3.) Refactored DataIndexer. This touched a lot of code. Added init(Map,Map) method and index(ObjectStream<Event>) method. Changed 1-Pass and 2-Pass DataIndexers. Everywhere 1-pass/2-pass indexers where created, I changed the constructor, and added the init and index methods.
4.) Changed GIS.doTrain(indexer) to use the parameters passed in the init method.
5.) QNTrainer \u2013 created a working init method. Changed the isValid method so it is not the init method.
#4 Make the GIS class work within the new training API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danielruss/opennlp refactorDataIndexer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit d281c7406faa5a4062bfc843377de9d37a2c6b50
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-21T20:18:08Z
see JIRA OPENNLP-880: Updated GIS/DataIndexer/QNTrainer
commit 78264f94f97804b3110f5c53da75b68c22b694b4
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-21T20:23:35Z
See OPENNLP-880: Changed GIS, EventTrainer, QNTrainer, DataIndexer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] opennlp pull request #14: OPENNLP-880: Refactor data indexer
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/opennlp/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] opennlp pull request #14: Refactor data indexer
Posted by danielruss <gi...@git.apache.org>.
Github user danielruss closed the pull request at:
https://github.com/apache/opennlp/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] opennlp pull request #14: Refactor data indexer
Posted by danielruss <gi...@git.apache.org>.
GitHub user danielruss reopened a pull request:
https://github.com/apache/opennlp/pull/14
Refactor data indexer
Added a patch that changes multiple items (Sorry That I did not fix 1 item at a time-I am a scientist not a software engineer):
1.) Added method to EventTrainer \u2013 train(DataIndexer indexer) \u2013Then I added the method to AbstractEventTrainer. No other code needed to be changed.
2.) Created a new class \u2013 PluggableParmeters: Only AbstractTrainers had access to getXXXParam(Value,Default). So I pulled out this functionality into a separate class. Now both AbstractTrainers and AbstractDataIndexers can hold parameters.
3.) Refactored DataIndexer. This touched a lot of code. Added init(Map,Map) method and index(ObjectStream<Event>) method. Changed 1-Pass and 2-Pass DataIndexers. Everywhere 1-pass/2-pass indexers where created, I changed the constructor, and added the init and index methods.
4.) Changed GIS.doTrain(indexer) to use the parameters passed in the init method.
5.) QNTrainer \u2013 created a working init method. Changed the isValid method so it is not the init method.
#4 Make the GIS class work within the new training API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danielruss/opennlp refactorDataIndexer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit d281c7406faa5a4062bfc843377de9d37a2c6b50
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-21T20:18:08Z
see JIRA OPENNLP-880: Updated GIS/DataIndexer/QNTrainer
commit 78264f94f97804b3110f5c53da75b68c22b694b4
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-21T20:23:35Z
See OPENNLP-880: Changed GIS, EventTrainer, QNTrainer, DataIndexer
commit a53b6d39671b986327929c6a4e128454b697b665
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-22T14:21:51Z
change method signatures to use List instead of LinkedList
commit f29fa1134610ab69824621eb43761d2672558fe6
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-22T16:48:21Z
OPENNLP:880 Fixed whitespace Issue
commit 605a41c1b2c2bacee56bdf3932097a8a67a51f86
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-23T17:04:48Z
Added method for the refactored index
commit 00c43d92865665b21dff805cd8eabb814ef604b9
Author: Daniel Russ <dr...@mail.nih.gov>
Date: 2016-12-23T18:58:18Z
OPENNLP-880 index() signature didnt match in 1passRVindexer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---