[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143684236


##########
.github/workflows/ci.yml:
##########
@@ -39,9 +39,26 @@ jobs:
           # CPPFLAGS are not recognized by cmake, so we have to force them to CFLAGS and CXXFLAGS to have flex 2.6 working
           ./bootstrap.sh -e -t && cd build  && cmake -DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} ${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" -DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON -DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
       - name: test
-        run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+        id: test
+        run: |
+          ulimit -c 1024000

Review Comment:
   According to POSIX, `ulimit -c` is specified in 512 byte increments, but the bash man page specifies 1024 byte increments, except when in posix mode. I don't know which limit applies here, so I think it would be nice to clarify it in a comment, what this limit means in terms of data size. 500 MiB or 1000 MiB?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org