[GitHub] [zookeeper] li4wang edited a comment on pull request #1802: ZOOKEEPER-4455: Move to https://reload4j.qos.ch/ (remove log4j1)

[GitBox <gi...@apache.org>]

li4wang edited a comment on pull request #1802:
URL: https://github.com/apache/zookeeper/pull/1802#issuecomment-1049279741


   > The only issues I saw was the removal of the JMX MBean stuff,  but ZooKeeper should already handle that fine.
   
   Yeah, I noticed JMX MBean stuff was removed from reload4j-1.2.18.5 and 1.2.19, but I don't know if the removal was intended and permanent. I posted a message to the  reload4j distribution list but haven't got response yet.
   
   I replaced log4j1.2.17 with reload4j-1.2.18.3  and slf4j-reload4j-1.7.35 for the legacy Zookeeper 3.4 release and it works great.
   
   Yes, Zookeeper still tries to instantiate the `org.apache.log4j.jmx.HierarchyDynamicMBean ` in  ManagedUtil.registerLog4jMBeans, but the caller catches the JMSException and logs it as warn.
   
   https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java#L68
   
   https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java#L102-L103
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org