You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/17 22:10:54 UTC

[GitHub] [arrow-datafusion] andygrove opened a new issue, #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

andygrove opened a new issue, #2565:
URL: https://github.com/apache/arrow-datafusion/issues/2565

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   When adding new `Expr` variants, we should also be adding code to `datafusion_proto` to handle them but we are not forced into doing this today because the match statement handles the `_` case with an error.
   
   **Describe the solution you'd like**
   Support all current `Expr` variants in and remove the `_` case.
   
   **Describe alternatives you've considered**
   None
   
   **Additional context**
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2565:
URL: https://github.com/apache/arrow-datafusion/issues/2565#issuecomment-1129386760

   Currently `datafusion.proto` only handles expressions and not logical plans, but that will have to change if we want to support subquery expressions. Ballista already has support for plans so maybe we move some of that code to DataFusion? Another option would be to look at Substrait but that may be a significant amount of work.
   
   fyi @alamb @carols10cents @Ted-Jiang @thinkharderdev since you have contributed to this file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] thinkharderdev commented on issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on issue #2565:
URL: https://github.com/apache/arrow-datafusion/issues/2565#issuecomment-1129929039

   Yeah, agreed. I think it makes sense to move all serialization into datafusion-proto. It might be useful as well if we move forward with breaking Ballista out into it's own repo to help ensure that constructs added to DataFusion are always serializable. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Ted-Jiang commented on issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on issue #2565:
URL: https://github.com/apache/arrow-datafusion/issues/2565#issuecomment-1129940752

   +1 , remove the `_` case, will give error at compile time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove closed issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

Posted by GitBox <gi...@apache.org>.
andygrove closed issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`
URL: https://github.com/apache/arrow-datafusion/issues/2565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #2565: `datafusion_proto` crate should have exhaustive match statements for handling `Expr`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2565:
URL: https://github.com/apache/arrow-datafusion/issues/2565#issuecomment-1129925412

   I would think we should move the code for serializing logical plans into datafusion.proto as well 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org