[GitHub] [iceberg] rdblue commented on a diff in pull request #6404: Core: Allow configuring metrics reporter impl via Catalog property

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046056595


##########
api/src/main/java/org/apache/iceberg/metrics/LoggingMetricsReporter.java:
##########
@@ -28,6 +28,11 @@
  */
 public class LoggingMetricsReporter implements MetricsReporter {
   private static final Logger LOG = LoggerFactory.getLogger(LoggingMetricsReporter.class);
+  private static final LoggingMetricsReporter INSTANCE = new LoggingMetricsReporter();

Review Comment:
   This is in two PRs now, right? Should we separate it out into its own so we don't have conflicting PRs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org