You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/09/16 09:52:59 UTC
[PR] HDDS-16483. zizmor-action upgrade may break silently [ozone]
adoroszlai opened a new pull request, #11249:
URL: https://github.com/apache/ozone/pull/11249
## What changes were proposed in this pull request?
(Similar to https://github.com/apache/ratis-thirdparty/pull/195, except the workflow fixes to satisfy new `zizmor-action` rules, since it is not yet upgraded to 0.6.4 here.)
Rules introduced by new versions `zizmor-action` may fail silently in the [PR](https://github.com/apache/ratis-thirdparty/pull/193) that bumps ithe action. Problem is [reported](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860/job/104701697687#step:3:209) in details, but check still [passes](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860). The failure will surface only in [forks](https://github.com/adoroszlai/ratis-thirdparty/actions/runs/35070400137) or in PRs changing the offending workflow files.
With GitHub Advanced Security enabled for `zizmor-action` (the default setting), problems are reported in the repo's [Code scanning](https://github.com/apache/ratis-thirdparty/security/code-scanning) page. When this feature is disabled, any problems reported cause the check to fail.
This change keeps Advanced Security only for push events in Apache repo, which allows pull requests touching only `zizmor.yaml` (e.g. for version bump) to catch problems in other files.
https://issues.apache.org/jira/browse/HDDS-16483
## How was this patch tested?
Similar change tested in detail in https://github.com/apache/ratis-thirdparty/pull/195.
zizmor check in fork:
https://github.com/adoroszlai/ozone/actions/runs/35079614905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16483. zizmor-action upgrade may break silently [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11249:
URL: https://github.com/apache/ozone/pull/11249#issuecomment-5696594889
Thanks @dombizita for the review. Please also take a look at same change in other repos when you have some time.
- https://github.com/apache/ozone-docker/pull/100
- https://github.com/apache/ozone-docker-runner/pull/110
- https://github.com/apache/ozone-docker-testkrb5/pull/61
- https://github.com/apache/ozone-helm-charts/pull/67
- https://github.com/apache/ozone-site/pull/555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16483. zizmor-action upgrade may break silently [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11249:
URL: https://github.com/apache/ozone/pull/11249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org