You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/01/07 20:19:34 UTC
Review Request 69690: Changed the gRPC make variables for protoc
detection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69690/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Since gRPC's Makefile use `HAS_XXX` as public-facing third-party
library control flags, we should use them to detect protoc instead of
setting the `NO_PROTOC` internal variable.
Diffs
-----
3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87
Diff: https://reviews.apache.org/r/69690/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69690: Changed the gRPC make variables for protoc
detection.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69690/#review211738
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 7, 2019, 8:19 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69690/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 8:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC's Makefile use `HAS_XXX` as public-facing third-party
> library control flags, we should use them to detect protoc instead of
> setting the `NO_PROTOC` internal variable.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87
>
>
> Diff: https://reviews.apache.org/r/69690/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>