You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/12 16:43:22 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5841: Add sleep to make DS test pass

rawlinp commented on a change in pull request #5841:
URL: https://github.com/apache/trafficcontrol/pull/5841#discussion_r631217906



##########
File path: traffic_ops/testing/api/v4/deliveryservices_test.go
##########
@@ -296,6 +296,7 @@ func DeleteCDNOldSSLKeys(t *testing.T) {
 	if err != nil {
 		t.Fatalf("couldn't snap CDN: %v", err)
 	}
+	time.Sleep(5 * time.Second)

Review comment:
       instead of a simple sleep, can we use a shorter sleep in the retry loop and check each time? When using Postgres, the update could complete much earlier than Riak, so the tests wouldn't have to wait as long




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org