You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2024/09/16 13:44:33 UTC

Re: [PR] [WIP] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

mumrah commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1761190439


##########
.github/workflows/build.yml:
##########
@@ -83,6 +83,14 @@ jobs:
         run: python .github/scripts/checkstyle.py
         env:
           GITHUB_WORKSPACE: ${{ github.workspace }}
+      - name: Update Floating 'cached' Tag on Successful Trunk Build
+        if: success()

Review Comment:
   This workflow is used by PRs as well as trunk. We need to make sure we're only tagging the commits on trunk. You could do that here with an additional condition, or add a trunk-only step to ci.yml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org