[jira] [Work logged] (BEAM-5967) ProtoCoder doesn't support DynamicMessage

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5967?focusedWorklogId=321449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321449 ]

ASF GitHub Bot logged work on BEAM-5967:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/19 18:52
            Start Date: 01/Oct/19 18:52
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on issue #8496: [BEAM-5967] Add handling of DynamicMessage in ProtoCoder
URL: https://github.com/apache/beam/pull/8496#issuecomment-537177956
 
 
   r: @TheNeuralBit 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 321449)
    Time Spent: 4h  (was: 3h 50m)

> ProtoCoder doesn't support DynamicMessage
> -----------------------------------------
>
>                 Key: BEAM-5967
>                 URL: https://issues.apache.org/jira/browse/BEAM-5967
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.8.0
>            Reporter: Alex Van Boxel
>            Assignee: Alex Van Boxel
>            Priority: Major
>             Fix For: 2.17.0
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> The ProtoCoder does make some assumptions about static messages being available. The DynamicMessage doesn't have some of them, mainly because the proto schema is defined at runtime and not at compile time.
> Does it make sense to make a special coder for DynamicMessage or build it into the normal ProtoCoder.
> Here is an example of the assumtion being made in the current Codec:
> {code:java}
> try {
>   @SuppressWarnings("unchecked")
>   T protoMessageInstance = (T) protoMessageClass.getMethod("getDefaultInstance").invoke(null);
>   @SuppressWarnings("unchecked")
>   Parser<T> tParser = (Parser<T>) protoMessageInstance.getParserForType();
>   memoizedParser = tParser;
> } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
>   throw new IllegalArgumentException(e);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)