You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/29 05:35:14 UTC
[GitHub] [superset] hushaoqing opened a new pull request, #21638: disable __REACT_DEVTOOLS_GLOBAL_HOOK__ in production mode
hushaoqing opened a new pull request, #21638:
URL: https://github.com/apache/superset/pull/21638
### SUMMARY
fix https://github.com/apache/superset/issues/20815
refer: https://stackoverflow.com/questions/42196819/disable-hide-download-the-react-devtools
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #20815
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21638: fix: disable __REACT_DEVTOOLS_GLOBAL_HOOK__ in production mode
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21638:
URL: https://github.com/apache/superset/pull/21638#issuecomment-1261834525
# [Codecov](https://codecov.io/gh/apache/superset/pull/21638?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21638](https://codecov.io/gh/apache/superset/pull/21638?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a158ae) into [master](https://codecov.io/gh/apache/superset/commit/b787c3fef4655c1142da3d827fe6766c853ffe72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b787c3f) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21638 +/- ##
==========================================
+ Coverage 66.81% 66.83% +0.02%
==========================================
Files 1798 1798
Lines 68763 68763
Branches 7326 7326
==========================================
+ Hits 45944 45958 +14
+ Misses 20944 20924 -20
- Partials 1875 1881 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.19% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/21638/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `66.18% <0.00%> (+5.75%)` | :arrow_up: |
| [...rd/components/nativeFilters/FilterBar/keyValue.tsx](https://codecov.io/gh/apache/superset/pull/21638/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2tleVZhbHVlLnRzeA==) | `40.74% <0.00%> (+22.22%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hushaoqing commented on pull request #21638: fix: disable __REACT_DEVTOOLS_GLOBAL_HOOK__ in production mode
Posted by GitBox <gi...@apache.org>.
hushaoqing commented on PR #21638:
URL: https://github.com/apache/superset/pull/21638#issuecomment-1272247721
Seems like it has been fixed.
Closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hushaoqing closed pull request #21638: fix: disable __REACT_DEVTOOLS_GLOBAL_HOOK__ in production mode
Posted by GitBox <gi...@apache.org>.
hushaoqing closed pull request #21638: fix: disable __REACT_DEVTOOLS_GLOBAL_HOOK__ in production mode
URL: https://github.com/apache/superset/pull/21638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org