[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4141: fix: shouldn't pass alias through into subquery.

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #4141:
URL: https://github.com/apache/arrow-datafusion/pull/4141#discussion_r1018486987


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -746,7 +746,7 @@ async fn test_physical_plan_display_indent_multi_children() {
         "          ProjectionExec: expr=[c2@0 as c2]",
         "            ProjectionExec: expr=[c1@0 as c2]",
         "              RepartitionExec: partitioning=RoundRobinBatch(9000)",
-        "                CsvExec: files=[ARROW_TEST_DATA/csv/aggregate_test_100.csv], has_header=true, limit=None, projection=[c1]",
+        "                CsvExec: files=[ARROW_TEST_DATA/csv/aggregate_test_100.csv], has_header=true, limit=None, projection=[c1, c2]",

Review Comment:
   It is confusing the alias `c2` with the column `c2`, so I am concerned that this could also introduce correctness issues. It would be good to understand this better before we merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org