You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:49:31 UTC

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4465: [INLONG-4464][Manager] Fix problems emerged from full link path tests

healchow commented on code in PR #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465#discussion_r887774178


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/FieldType.java:
##########
@@ -42,7 +42,7 @@ public enum FieldType {
     public static FieldType forName(String name) {
         Preconditions.checkNotNull(name, "FieldType should not be null");
         for (FieldType value : values()) {
-            if (value.toString().equals(name)) {
+            if (value.toString().equalsIgnoreCase(name)) {

Review Comment:
   I checked again, and this scenario needs ignore case, please change it back, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org