[jira] Commented: (WODEN-171) Remove QNameUtils class

["John Kaputin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WODEN-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513259 ] 

John Kaputin commented on WODEN-171:
------------------------------------

The 2 places this class is used are  SOAPModuleDeserializer and SOAPHeaderBlockDeserializer.

Need to change:
if (QNameUtils.matches(Constants.Q_ELEM_DOCUMENTATION, tempEl)

to:
if(Constants.Q_ELEM_DOCUMENTATION.equals(tempEl.getQName()))

> Remove QNameUtils class
> -----------------------
>
>                 Key: WODEN-171
>                 URL: https://issues.apache.org/jira/browse/WODEN-171
>             Project: Woden
>          Issue Type: Improvement
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>
> The QNameUtils class is not necessary and removing it will help with WODEN-67 to modularize the Woden build create DOM and OM specific binary jars.  This class has one method 'matches()' which compares a specified QName to the QName of a specified element object. It contains a hardcoded conditional switch to check the element object  type and then forwards to DOMQNameUtils.matches() or OMQNameUtils.matches(). Not very O/O! 
> This method is only used in 2 places and can be easily replaced by using the QName.equals() method of directly. By eliminating this class and its dual compile dependency on DOM and OM, we can modularize the Maven build to support WODEN-67.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org