You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/02 06:42:49 UTC

[GitHub] [ozone] kaijchen opened a new pull request, #3476: HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed

kaijchen opened a new pull request, #3476:
URL: https://github.com/apache/ozone/pull/3476

   ## What changes were proposed in this pull request?
   
   Fix intermittent failure in TestOzoneECClient#testExcludeOnDNMixed.
   
   https://github.com/apache/ozone/runs/6701276416?check_suite_focus=true
   
   ## What is the link to the Apache JIRA
   
   HDDS-6823
   
   ## How was this patch tested?
   
   Tested manually by repeating the test 100x in `for` loop.
   And also tested with all other tests in TestOzoneECClient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kaijchen commented on pull request #3476: HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed

Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3476:
URL: https://github.com/apache/ozone/pull/3476#issuecomment-1144506948

   @umamaheswararao previously, running this test alone with 100x is fine.
   But it fails when running with other tests in `TestOzoneECClient`.
   
   I didn't find any issues in shared contexts with other tests,
   but imitating `testNodeFailuresWhileWriting` seems fixes this problem.
   I'm not exacly sure why.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kaijchen commented on pull request #3476: HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed

Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3476:
URL: https://github.com/apache/ozone/pull/3476#issuecomment-1145543841

   Thanks @umamaheswararao for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao commented on pull request #3476: HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed

Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on PR #3476:
URL: https://github.com/apache/ozone/pull/3476#issuecomment-1145107476

   LGTM, let's see if this fixed other PR test failures.
   I can only see pre allocated blocks vs lazily allocated. I think this will do 2 blocks preallocated compared to previous change.
   If preallocated 10 nodes will be used, otherwise it may reuse few nodes from previous. Anyway for this tests, preallocating is ok to have better predicted assertions. It would be good to document about this fact if that's true. ANyway for unblocking others I am going ahead to commit this test changes. Thanks a lot @kaijchen for quick investigation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao merged pull request #3476: HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed

Posted by GitBox <gi...@apache.org>.
umamaheswararao merged PR #3476:
URL: https://github.com/apache/ozone/pull/3476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org