You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/15 06:15:01 UTC
[GitHub] [incubator-nuttx] zouboan opened a new pull request #5235: Porting nuttx to SPARC V8
zouboan opened a new pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235
## Summary
I finished porting NuttX to SPARC V8 last year, Include architecture support code and board support code, I also verified the Tickless OS mode and ELF file separate load on SPARC V8 architecture
## Impact
Someone can run NuttX on AT697F(based on LEON 2)
## Testing
I have verified compile with apps and ELF file separate load.All this work has been tested on real hardware
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#discussion_r785279639
##########
File path: boards/Kconfig
##########
@@ -3345,6 +3368,7 @@ if ARCH_CHIP_STM32
source "boards/arm/stm32/common/Kconfig"
endif
+
Review comment:
what's mean master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#issuecomment-1013627956
@zouboan please report the style issue reported here:
https://github.com/apache/incubator-nuttx/runs/4825416188?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#discussion_r785278030
##########
File path: boards/Kconfig
##########
@@ -3345,6 +3368,7 @@ if ARCH_CHIP_STM32
source "boards/arm/stm32/common/Kconfig"
endif
+
Review comment:
don't need change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on a change in pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
zouboan commented on a change in pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#discussion_r785280100
##########
File path: boards/Kconfig
##########
@@ -3345,6 +3368,7 @@ if ARCH_CHIP_STM32
source "boards/arm/stm32/common/Kconfig"
endif
+
Review comment:
这个本来就有,我没改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#discussion_r785298218
##########
File path: boards/Kconfig
##########
@@ -3345,6 +3368,7 @@ if ARCH_CHIP_STM32
source "boards/arm/stm32/common/Kconfig"
endif
+
Review comment:
@zouboan mister Xiang is commenting about the new line ("\n") that you added at end of the Kconfig, see line 3371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on a change in pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
zouboan commented on a change in pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#discussion_r785279003
##########
File path: boards/Kconfig
##########
@@ -3345,6 +3368,7 @@ if ARCH_CHIP_STM32
source "boards/arm/stm32/common/Kconfig"
endif
+
Review comment:
This is already there in master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235#issuecomment-1013628365
BTW, it's better to enable the daily ci to ensure the modification in the future doesn't break sparc v8:
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/cibuild.sh
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/testlist/other.dat#L13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan closed pull request #5235: Porting nuttx to SPARC V8
Posted by GitBox <gi...@apache.org>.
zouboan closed pull request #5235:
URL: https://github.com/apache/incubator-nuttx/pull/5235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org