You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebastien Dubois (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 20:32:30 UTC
[jira] [Created] (CODEC-139) DigestUtils: additional utility
methods
DigestUtils: additional utility methods
---------------------------------------
Key: CODEC-139
URL: https://issues.apache.org/jira/browse/CODEC-139
Project: Commons Codec
Issue Type: Improvement
Reporter: Sebastien Dubois
Priority: Trivial
Attachments: DigestUtils-patch.txt
I've slightly modified the DigestUtils class:
- changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
- added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-139) DigestUtils: additional utility
methods
Posted by "Sebastien Dubois (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastien Dubois updated CODEC-139:
-----------------------------------
Attachment: DigestUtils-patch.txt
> DigestUtils: additional utility methods
> ---------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-139) DigestUtils: add updateDigest methods
and make methods public.
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory resolved CODEC-139.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.7
Committed revision 1328553.
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Fix For: 1.7
>
> Attachments: DigestUtils-patch-updated-2012-04-20.txt, DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-139) DigestUtils: add updateDigest methods
and make methods public.
Posted by "Paolo Calabro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Calabro updated CODEC-139:
--------------------------------
Attachment: guavacourt-hooke1-qrcode-SMALL.png
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Fix For: 1.7
>
> Attachments: DigestUtils-patch.txt, DigestUtils-patch-updated-2012-04-20.txt, guavacourt-hooke1-qrcode-SMALL.png
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-139) DigestUtils: additional utility
methods
Posted by "Gary D. Gregory (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258270#comment-13258270 ]
Gary D. Gregory commented on CODEC-139:
---------------------------------------
Hello Sebastian:
Thank you for the patch.
A couple of issues before this can go further:
- No unit tests
- The Javadoc for the updateDigest methods do not match the code. The docs talk about updating the digest but the code calls the digest method which does an update AND then completes the digest computation. Which way do you really mean? Plain update? Update AND complete (aka digest)? Unit tests would help define the user cases.
Thank you,
Gary
> DigestUtils: additional utility methods
> ---------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-139) DigestUtils: additional utility
methods
Posted by "Sebastien Dubois (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258466#comment-13258466 ]
Sebastien Dubois commented on CODEC-139:
----------------------------------------
Hello Gary, thanks for taking time to review this.
You're right, I didn't do my homework correctly and didn't provide unit tests. Also, I failed to RTFM and didn't see that I should've been calling the 'update' methods of MessageDigest instead of 'digest' this was just plain wrong!
I'll try and upload a better version of my patch asap.
> DigestUtils: additional utility methods
> ---------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-139) DigestUtils: additional utility
methods
Posted by "Sebastien Dubois (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastien Dubois updated CODEC-139:
-----------------------------------
Attachment: DigestUtils-patch-updated-2012-04-20.txt
Updated version of the patch with unit tests & correct code
> DigestUtils: additional utility methods
> ---------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch-updated-2012-04-20.txt, DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-139) DigestUtils: add updateDigest methods
and make methods public.
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated CODEC-139:
----------------------------------
Summary: DigestUtils: add updateDigest methods and make methods public. (was: DigestUtils: additional utility methods)
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch-updated-2012-04-20.txt, DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CODEC-139) DigestUtils: add updateDigest methods
and make methods public.
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory closed CODEC-139.
---------------------------------
Released in 1.7 today.
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Fix For: 1.7
>
> Attachments: DigestUtils-patch.txt, DigestUtils-patch-updated-2012-04-20.txt, guavacourt-hooke1-qrcode-SMALL.png, guavacourt-psychicr-qrcode-SMALL.png
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-139) DigestUtils: add updateDigest
methods and make methods public.
Posted by "Paolo Calabro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446449#comment-13446449 ]
Paolo Calabro commented on CODEC-139:
-------------------------------------
The genie in bottle living right here
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Fix For: 1.7
>
> Attachments: DigestUtils-patch.txt, DigestUtils-patch-updated-2012-04-20.txt, guavacourt-hooke1-qrcode-SMALL.png, guavacourt-psychicr-qrcode-SMALL.png
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-139) DigestUtils: add updateDigest methods
and make methods public.
Posted by "Paolo Calabro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Calabro updated CODEC-139:
--------------------------------
Attachment: guavacourt-psychicr-qrcode-SMALL.png
> DigestUtils: add updateDigest methods and make methods public.
> --------------------------------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Fix For: 1.7
>
> Attachments: DigestUtils-patch.txt, DigestUtils-patch-updated-2012-04-20.txt, guavacourt-hooke1-qrcode-SMALL.png, guavacourt-psychicr-qrcode-SMALL.png
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the provided MessageDigest. The advantage for the one that accepts a String argument is that it keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which accepts a byte array is there for consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira