You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/04/14 21:34:18 UTC
Review Request 33185: DISPATCH-135: move qd_delivery_t into router
engine
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33185/
-----------------------------------------------------------
Review request for qpid, Alan Conway and Ted Ross.
Bugs: DISPATCH-135
https://issues.apache.org/jira/browse/DISPATCH-135
Repository: qpid-dispatch
Description
-------
This patch removes the container's qd_delivery_t structure and moves it into the router layer as qd_router_delivery_t.
This patch is minimal - I tried to limit it to renaming and moving code around.
Diffs
-----
trunk/include/qpid/dispatch/container.h 1673424
trunk/include/qpid/dispatch/message.h 1673424
trunk/include/qpid/dispatch/router.h 1673424
trunk/src/CMakeLists.txt 1673424
trunk/src/container.c 1673424
trunk/src/message.c 1673424
trunk/src/router_delivery.c PRE-CREATION
trunk/src/router_forwarders.c 1673424
trunk/src/router_node.c 1673424
trunk/src/router_private.h 1673424
trunk/src/waypoint.c 1673424
Diff: https://reviews.apache.org/r/33185/diff/
Testing
-------
All unit tests pass.
Thanks,
Kenneth Giusti
Re: Review Request 33185: DISPATCH-135: move qd_delivery_t into
router engine
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33185/#review80088
-----------------------------------------------------------
Ship it!
Ship It!
- Alan Conway
On April 14, 2015, 7:34 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33185/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 7:34 p.m.)
>
>
> Review request for qpid, Alan Conway and Ted Ross.
>
>
> Bugs: DISPATCH-135
> https://issues.apache.org/jira/browse/DISPATCH-135
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This patch removes the container's qd_delivery_t structure and moves it into the router layer as qd_router_delivery_t.
>
> This patch is minimal - I tried to limit it to renaming and moving code around.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/container.h 1673424
> trunk/include/qpid/dispatch/message.h 1673424
> trunk/include/qpid/dispatch/router.h 1673424
> trunk/src/CMakeLists.txt 1673424
> trunk/src/container.c 1673424
> trunk/src/message.c 1673424
> trunk/src/router_delivery.c PRE-CREATION
> trunk/src/router_forwarders.c 1673424
> trunk/src/router_node.c 1673424
> trunk/src/router_private.h 1673424
> trunk/src/waypoint.c 1673424
>
> Diff: https://reviews.apache.org/r/33185/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 33185: DISPATCH-135: move qd_delivery_t into
router engine
Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33185/#review80093
-----------------------------------------------------------
Ship it!
This is a major improvement.
- Ted Ross
On April 14, 2015, 3:34 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33185/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 3:34 p.m.)
>
>
> Review request for qpid, Alan Conway and Ted Ross.
>
>
> Bugs: DISPATCH-135
> https://issues.apache.org/jira/browse/DISPATCH-135
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This patch removes the container's qd_delivery_t structure and moves it into the router layer as qd_router_delivery_t.
>
> This patch is minimal - I tried to limit it to renaming and moving code around.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/container.h 1673424
> trunk/include/qpid/dispatch/message.h 1673424
> trunk/include/qpid/dispatch/router.h 1673424
> trunk/src/CMakeLists.txt 1673424
> trunk/src/container.c 1673424
> trunk/src/message.c 1673424
> trunk/src/router_delivery.c PRE-CREATION
> trunk/src/router_forwarders.c 1673424
> trunk/src/router_node.c 1673424
> trunk/src/router_private.h 1673424
> trunk/src/waypoint.c 1673424
>
> Diff: https://reviews.apache.org/r/33185/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Kenneth Giusti
>
>