You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/09 03:47:23 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4100: Implement utime and futimes
xiaoxiang781216 opened a new pull request #4100:
URL: https://github.com/apache/incubator-nuttx/pull/4100
## Summary
libc: Move the declaration of futimens from sys/time.h to sys/stat.h
libc: Implement utime on top of utimes
libc: Implement futimes on top of futimens
Note: the real file system level change will provide in the upcoming patchset.
## Impact
New API
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4100: Implement utime and futimes
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4100:
URL: https://github.com/apache/incubator-nuttx/pull/4100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4100: Implement utime and futimes
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4100:
URL: https://github.com/apache/incubator-nuttx/pull/4100#discussion_r666940280
##########
File path: include/utime.h
##########
@@ -0,0 +1,81 @@
+/****************************************************************************
+ * include/utime.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_UTIME_H
+#define __INCLUDE_UTIME_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Type Definitions
+ ****************************************************************************/
+
+struct utimbuf
+{
+ time_t actime; /* Access time */
+ time_t modtime; /* Modification time */
+};
+
+/****************************************************************************
+ * Public Function Prototypes
+ ****************************************************************************/
+
+#undef EXTERN
+#if defined(__cplusplus)
+#define EXTERN extern "C"
+extern "C"
+{
+#else
+#define EXTERN extern
+#endif
+
+/****************************************************************************
+ * Name: utime
+ *
+ * Description:
+ * The utime() system call changes the access and modification times of
+ * the inode specified by path to the actime and modtime fields of times
+ * respectively.
+ * If times is NULL, then the access and modification times of the file
+ * are set to the current time.
+ *
+ * Input Parameters:
+ * path - Specifies the file to be modified
+ * timbuf - Specifies the time value to set
+ *
+ * Returned Value:
+ * Upon successful completion, 0 shall be returned. Otherwise, -1 shall
+ * be returned and errno shall be set to indicate the error, and the file
+ * times shall not be affected.
+ *
+ ****************************************************************************/
+
+int utime(FAR const char *path, FAR const struct utimbuf *timbuf);
Review comment:
```suggestion
* Input Parameters:
* path - Specifies the file to be modified
* times - Specifies the time value to set
*
* Returned Value:
* Upon successful completion, 0 shall be returned. Otherwise, -1 shall
* be returned and errno shall be set to indicate the error, and the file
* times shall not be affected.
*
****************************************************************************/
int utime(FAR const char *path, FAR const struct utimbuf *times);
```
It is better to use the same identifiers from the OpenGroup standard, also to stay coherent with the our description which already mentions `times`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4100: Implement utime and futimes
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4100:
URL: https://github.com/apache/incubator-nuttx/pull/4100#discussion_r666942164
##########
File path: libs/libc/unistd/lib_utime.c
##########
@@ -0,0 +1,47 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_utime.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/time.h>
+#include <utime.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int utime(FAR const char *path, FAR const struct utimbuf *timbuf)
+{
+ struct timeval times[2];
+
+ if (timbuf == NULL)
+ {
+ return utimes(path, NULL);
+ }
+
+ times[0].tv_sec = timbuf->actime;
+ times[0].tv_usec = 0;
+ times[1].tv_sec = timbuf->modtime;
+ times[1].tv_usec = 0;
+
+ return utimes(path, times);
+}
Review comment:
```suggestion
int utime(FAR const char *path, FAR const struct utimbuf *times)
{
struct timeval timbuf[2];
if (times == NULL)
{
return utimes(path, NULL);
}
timbuf[0].tv_sec = times->actime;
timbuf[0].tv_usec = 0;
timbuf[1].tv_sec = times->modtime;
timbuf[1].tv_usec = 0;
return utimes(path, timbuf);
}
```
Complement to my previous suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4100: Implement utime and futimes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4100:
URL: https://github.com/apache/incubator-nuttx/pull/4100#discussion_r667054725
##########
File path: include/utime.h
##########
@@ -0,0 +1,81 @@
+/****************************************************************************
+ * include/utime.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_UTIME_H
+#define __INCLUDE_UTIME_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Type Definitions
+ ****************************************************************************/
+
+struct utimbuf
+{
+ time_t actime; /* Access time */
+ time_t modtime; /* Modification time */
+};
+
+/****************************************************************************
+ * Public Function Prototypes
+ ****************************************************************************/
+
+#undef EXTERN
+#if defined(__cplusplus)
+#define EXTERN extern "C"
+extern "C"
+{
+#else
+#define EXTERN extern
+#endif
+
+/****************************************************************************
+ * Name: utime
+ *
+ * Description:
+ * The utime() system call changes the access and modification times of
+ * the inode specified by path to the actime and modtime fields of times
+ * respectively.
+ * If times is NULL, then the access and modification times of the file
+ * are set to the current time.
+ *
+ * Input Parameters:
+ * path - Specifies the file to be modified
+ * timbuf - Specifies the time value to set
+ *
+ * Returned Value:
+ * Upon successful completion, 0 shall be returned. Otherwise, -1 shall
+ * be returned and errno shall be set to indicate the error, and the file
+ * times shall not be affected.
+ *
+ ****************************************************************************/
+
+int utime(FAR const char *path, FAR const struct utimbuf *timbuf);
Review comment:
Done.
##########
File path: libs/libc/unistd/lib_utime.c
##########
@@ -0,0 +1,47 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_utime.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/time.h>
+#include <utime.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int utime(FAR const char *path, FAR const struct utimbuf *timbuf)
+{
+ struct timeval times[2];
+
+ if (timbuf == NULL)
+ {
+ return utimes(path, NULL);
+ }
+
+ times[0].tv_sec = timbuf->actime;
+ times[0].tv_usec = 0;
+ times[1].tv_sec = timbuf->modtime;
+ times[1].tv_usec = 0;
+
+ return utimes(path, times);
+}
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org