You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/08/03 13:43:18 UTC
[GitHub] brooklyn-server pull request #789: Adds DynamicCluster.START_TIMEOUT
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/789
Adds DynamicCluster.START_TIMEOUT
Similar to `SoftwareProcess`, this allows a dynamic cluster to wait for
`service.isUp` before returning from `start()`. It defaults to not waiting
(for backwards compatibility).
Previously, it would return as soon as all the initial member’s start()
effectors had finished executing.
---
Note that the new test `testReportsServiceUpAsSoonAsQuorumSize()` just demonstrates existing behaviour - this PR does not change that behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server DynamicCluster-waitForServiceUp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 64d9862443c6bf2ed018ab717b43930914872484
Author: Aled Sage <al...@gmail.com>
Date: 2017-08-03T13:37:48Z
Adds DynamicCluster.START_TIMEOUT
Similar to SoftwareProcess, this allows a dynamic cluster to wait for
service.isUp before returning from `start`. It defaults to not waiting
(for backwards compatibility).
Previously, it would return as soon as all the initial member’s start()
effectors had finished executing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #789: Adds DynamicCluster.START_TIMEOUT
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/789
build failure is unrelated, but I'll add a commit here to try to fix it:
```
2017-08-03 15:53:13,507 INFO TESTNG FAILED: "Surefire test" - org.apache.brooklyn.camp.brooklyn.catalog.CatalogMakeOsgiBundleTest.testCatalogBomFromBundleWithManifest() finished in 116 ms
java.lang.AssertionError: attribute=Sensor: a.sensor (java.lang.String); val=null
at org.apache.brooklyn.test.Asserts.fail(Asserts.java:758)
at org.apache.brooklyn.test.Asserts.assertTrue(Asserts.java:737)
at org.apache.brooklyn.core.entity.EntityAsserts.assertAttribute(EntityAsserts.java:103)
at org.apache.brooklyn.camp.brooklyn.catalog.CatalogMakeOsgiBundleTest.assertBasic1DeploysAndHasSensor(CatalogMakeOsgiBundleTest.java:123)
at org.apache.brooklyn.camp.brooklyn.catalog.CatalogMakeOsgiBundleTest.testCatalogBomFromBundleWithManifest(CatalogMakeOsgiBundleTest.java:114)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #789: Adds DynamicCluster.START_TIMEOUT
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/789#discussion_r131175678
--- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -485,6 +491,17 @@ protected void doStart() {
}
}
+ public void waitForServiceUp() {
--- End diff --
Good point - will change to protected (I copied it from `SoftwareProcessImpl`, where these are public).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #789: Adds DynamicCluster.START_TIMEOUT
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/789#discussion_r131145665
--- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -485,6 +491,17 @@ protected void doStart() {
}
}
+ public void waitForServiceUp() {
--- End diff --
why public?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #789: Adds DynamicCluster.START_TIMEOUT
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---