You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "shuyouZZ (via GitHub)" <gi...@apache.org> on 2023/10/26 03:42:14 UTC
[PR] [SPARK-45669][CORE] Ensure the continuity of rolling log index [spark]
shuyouZZ opened a new pull request, #43534:
URL: https://github.com/apache/spark/pull/43534
### What changes were proposed in this pull request?
Ensure the continuity of rolling log index.
### Why are the changes needed?
Current the log file index will increment before running `initLogFile()`. When running `rollEventlogFile()`, the index will increment first, then create new log file to init event log writer.
If the log file creation fails, `initLogFile()` will throw an exception and stop running the method. The log file index will still increment next time `rollEventLogFile()` is called,
which will cause the file index to become discontinuous. EventLogFileReader can not read the event log files normally.
Therefore, we need to update the logic here to ensure the continuity of rolling log index.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit test
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45669][CORE] Ensure the continuity of rolling log index [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43534: [SPARK-45669][CORE] Ensure the continuity of rolling log index
URL: https://github.com/apache/spark/pull/43534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45669][CORE] Ensure the continuity of rolling log index [spark]
Posted by "shuyouZZ (via GitHub)" <gi...@apache.org>.
shuyouZZ closed pull request #43534: [SPARK-45669][CORE] Ensure the continuity of rolling log index
URL: https://github.com/apache/spark/pull/43534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45669][CORE] Ensure the continuity of rolling log index [spark]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #43534:
URL: https://github.com/apache/spark/pull/43534#issuecomment-1794229604
ping @dongjoon-hyun @srowen @cloud-fan Could you take a review about this history server issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45669][CORE] Ensure the continuity of rolling log index [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43534:
URL: https://github.com/apache/spark/pull/43534#issuecomment-1945132826
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org