You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/02 00:20:39 UTC

[GitHub] [pulsar] rdhabalia commented on a change in pull request #9412: [pulsar-broker] Handle bad-version in metadata-store if broker updates zk-metadata from zk-client

rdhabalia commented on a change in pull request #9412:
URL: https://github.com/apache/pulsar/pull/9412#discussion_r568233796



##########
File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataCacheTest.java
##########
@@ -258,4 +263,28 @@ public void readModifyUpdateOrCreate(String provider, String url) throws Excepti
         assertEquals(newValue1.get().b, 2);
     }
 
+    @Test
+    public void readModifyUpdateBadVersionRetry() throws Exception {
+        String url =  zks.getConnectionString(); 
+        @Cleanup
+        ZKMetadataStore store = (ZKMetadataStore) MetadataStoreFactory.create(url, MetadataStoreConfig.builder().build());

Review comment:
       good point. addressed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org