[jira] [Commented] (TAP5-2197) @Import without stack puts imported stylesheet before the core stack ones

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855815#comment-13855815 ] 

Howard M. Lewis Ship commented on TAP5-2197:
--------------------------------------------

I'm finding this bug fix regrettable and may need to back it out.  The main issue here is that there is no interaction between importing a stylesheet and importing a stack, especially the core stack. That could have been changed easily: importing a stylesheet imports the core stack implicitly, just the same way as any JavaScript imports implicilty import the core stack.

All of this reversing and stuff seems problematic to me.  

In addition, the @Import annotation doesn't have to go on the class, it can go on any method, including a render phase method, thus simply moving the @Import from the class to an {{afterRender()}} method would address most of the concerns here.

> @Import without stack puts imported stylesheet before the core stack ones
> -------------------------------------------------------------------------
>
>                 Key: TAP5-2197
>                 URL: https://issues.apache.org/jira/browse/TAP5-2197
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Geoff Callender
>            Assignee: Thiago H. de Paula Figueiredo
>             Fix For: 5.4
>
>
> I'm having trouble overriding the core css. I want to override the css of the bootstrap classes...
> When I do the following import, the page renders a link to my css BEFORE the links to the core css files. No good.
> 	@Import(stylesheet = { "context:css/mystylesheet.css" })
> BUT, when I do the following instead, the page renders in the right order, ie. a link to my css AFTER the links to the core css. Yay.
> 	@Import(stack = { "core" }, stylesheet = { "context:css/mystylesheet.css" })
> Is this a bug or expected behaviour?
> Cheers,
> Geoff



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)