You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Luke Cwik (Jira)" <ji...@apache.org> on 2020/04/23 16:40:00 UTC

[jira] [Resolved] (BEAM-3227) Consider sharing Udf/SkdFunctionSpec records via pointer

     [ https://issues.apache.org/jira/browse/BEAM-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Cwik resolved BEAM-3227.
-----------------------------
    Fix Version/s: Not applicable
       Resolution: Won't Fix

Making this change would now be backwards incompatible.

> Consider sharing Udf/SkdFunctionSpec records via pointer
> --------------------------------------------------------
>
>                 Key: BEAM-3227
>                 URL: https://issues.apache.org/jira/browse/BEAM-3227
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Priority: Major
>             Fix For: Not applicable
>
>
> Coders are stored by pointer, because they are often repeated and a common source of huge pipeline descriptions.
> We considered doing the same for all UDFs but decided not to, based on the logic that they are not as often identical and will rarely implement the equals() needed to actually share encoded versions.
> However, in the presence of generated code, it is very likely that DoFns and CombineFns are repeated, and also much more likely that they have meaningful equals(), so there could be size savings.
> None of this is terribly important for storage or transmission, but has more to do with arbitrary and small size limits that occur in some API frameworks or database column types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)