You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/07/23 06:12:27 UTC
[PR] feat: serialize ASOF join plans [datafusion]
Xuanwo opened a new pull request, #23832:
URL: https://github.com/apache/datafusion/pull/23832
## Which issue does this PR close?
- Part of #318.
- Umbrella PR: #23738.
- Depends on #23829 (and transitively #23828).
## Rationale for this change
This is the serialization layer of the ASOF JOIN stack. It gives logical and
physical ASOF plans explicit protobuf representations without coupling wire
format review to SQL or DataFrame APIs.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
https://github.com/Xuanwo/datafusion/compare/xuanwo/asof-logical...xuanwo/asof-proto
## What changes are included in this PR?
- Add protobuf messages and enum values for logical and physical ASOF joins.
- Encode and decode equality keys, ordered match expressions, match direction,
join constraint, and right output indices.
- Regenerate `prost` and `pbjson` sources with the repository generator.
- Add logical round trips for all four match directions.
- Add physical `AsOfJoinExec` round-trip coverage.
## Are these changes tested?
Yes:
- `./datafusion/proto-models/regen.sh`
- `cargo fmt --all`
- `cargo clippy --all-targets --all-features -- -D warnings`
- `cargo test -p datafusion-proto roundtrip_asof_join --all-features`
- Extended workspace tests from the contributor guide
## Are there any user-facing changes?
Logical and physical ASOF join plans can be serialized through
`datafusion-proto`. This extends the protobuf wire format with new message
variants.
This PR should be reviewed and merged after #23829. After its dependencies
squash-merge, this branch will be refreshed from `main` without rewriting its
published history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23832:
URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5449104089
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion v55.0.0 (current)
Built [ 58.310s] (current)
Parsing datafusion v55.0.0 (current)
Parsed [ 0.037s] (current)
Building datafusion v55.0.0 (baseline)
Built [ 58.058s] (baseline)
Parsing datafusion v55.0.0 (baseline)
Parsed [ 0.038s] (baseline)
Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.938s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 119.484s] datafusion
Building datafusion-expr v55.0.0 (current)
Built [ 28.534s] (current)
Parsing datafusion-expr v55.0.0 (current)
Parsed [ 0.081s] (current)
Building datafusion-expr v55.0.0 (baseline)
Built [ 29.479s] (baseline)
Parsing datafusion-expr v55.0.0 (baseline)
Parsed [ 0.083s] (baseline)
Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 1.857s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron
Failed in:
variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301
variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 61.171s] datafusion-expr
Building datafusion-optimizer v55.0.0 (current)
Built [ 27.216s] (current)
Parsing datafusion-optimizer v55.0.0 (current)
Parsed [ 0.033s] (current)
Building datafusion-optimizer v55.0.0 (baseline)
Built [ 26.976s] (baseline)
Parsing datafusion-optimizer v55.0.0 (baseline)
Parsed [ 0.035s] (baseline)
Checking datafusion-optimizer v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.226s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 55.420s] datafusion-optimizer
Building datafusion-physical-plan v55.0.0 (current)
Built [ 38.673s] (current)
Parsing datafusion-physical-plan v55.0.0 (current)
Parsed [ 0.159s] (current)
Building datafusion-physical-plan v55.0.0 (baseline)
Built [ 38.157s] (baseline)
Parsing datafusion-physical-plan v55.0.0 (baseline)
Parsed [ 0.160s] (baseline)
Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 1.010s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 79.474s] datafusion-physical-plan
Building datafusion-proto v55.0.0 (current)
Built [ 54.201s] (current)
Parsing datafusion-proto v55.0.0 (current)
Parsed [ 0.018s] (current)
Building datafusion-proto v55.0.0 (baseline)
Built [ 54.424s] (baseline)
Parsing datafusion-proto v55.0.0 (baseline)
Parsed [ 0.020s] (baseline)
Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.173s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 110.303s] datafusion-proto
Building datafusion-proto-models v55.0.0 (current)
Built [ 24.990s] (current)
Parsing datafusion-proto-models v55.0.0 (current)
Parsed [ 0.137s] (current)
Building datafusion-proto-models v55.0.0 (baseline)
Built [ 24.983s] (baseline)
Parsing datafusion-proto-models v55.0.0 (baseline)
Parsed [ 0.138s] (baseline)
Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 2.670s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron
Failed in:
variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1461
variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1461
variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83
variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 54.187s] datafusion-proto-models
Building datafusion-sql v55.0.0 (current)
Built [ 42.979s] (current)
Parsing datafusion-sql v55.0.0 (current)
Parsed [ 0.034s] (current)
Building datafusion-sql v55.0.0 (baseline)
Built [ 42.274s] (baseline)
Parsing datafusion-sql v55.0.0 (baseline)
Parsed [ 0.034s] (baseline)
Checking datafusion-sql v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.368s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 86.801s] datafusion-sql
Building datafusion-substrait v55.0.0 (current)
Built [ 305.027s] (current)
Parsing datafusion-substrait v55.0.0 (current)
Parsed [ 0.020s] (current)
Building datafusion-substrait v55.0.0 (baseline)
Built [ 307.346s] (baseline)
Parsing datafusion-substrait v55.0.0 (baseline)
Parsed [ 0.019s] (baseline)
Checking datafusion-substrait v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.312s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 614.595s] datafusion-substrait
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23832:
URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5055463112
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/23832?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.65835%` with `869 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.62%. Comparing base ([`47bd094`](https://app.codecov.io/gh/apache/datafusion/commit/47bd094c7fd2fc22cb2b94ee58458b87e365a56f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d36fd27`](https://app.codecov.io/gh/apache/datafusion/commit/d36fd277c1deb42d44b9d445c09795ed3a84ab2c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/23832?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/proto-models/src/generated/pbjson.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fproto-models%2Fsrc%2Fgenerated%2Fpbjson.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9wcm90by1tb2RlbHMvc3JjL2dlbmVyYXRlZC9wYmpzb24ucnM=) | 0.00% | [341 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/physical-plan/src/joins/asof\_join.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fphysical-plan%2Fsrc%2Fjoins%2Fasof_join.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1wbGFuL3NyYy9qb2lucy9hc29mX2pvaW4ucnM=) | 85.70% | [89 Missing and 55 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/expr/src/logical\_plan/plan.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fexpr%2Fsrc%2Flogical_plan%2Fplan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | 34.13% | [99 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/core/src/physical\_planner.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fcore%2Fsrc%2Fphysical_planner.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFubmVyLnJz) | 0.00% | [55 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/expr/src/logical\_plan/tree\_node.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fexpr%2Fsrc%2Flogical_plan%2Ftree_node.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vdHJlZV9ub2RlLnJz) | 0.00% | [43 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/proto/src/logical\_plan/mod.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fproto%2Fsrc%2Flogical_plan%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9wcm90by9zcmMvbG9naWNhbF9wbGFuL21vZC5ycw==) | 62.06% | [20 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/proto/src/physical\_plan/mod.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fproto%2Fsrc%2Fphysical_plan%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9wcm90by9zcmMvcGh5c2ljYWxfcGxhbi9tb2QucnM=) | 71.17% | [19 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/optimizer/src/analyzer/type\_coercion.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Foptimizer%2Fsrc%2Fanalyzer%2Ftype_coercion.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2FuYWx5emVyL3R5cGVfY29lcmNpb24ucnM=) | 0.00% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/optimizer/src/push\_down\_filter.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Foptimizer%2Fsrc%2Fpush_down_filter.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3B1c2hfZG93bl9maWx0ZXIucnM=) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/proto-models/src/generated/prost.rs](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&filepath=datafusion%2Fproto-models%2Fsrc%2Fgenerated%2Fprost.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9wcm90by1tb2RlbHMvc3JjL2dlbmVyYXRlZC9wcm9zdC5ycw==) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [6 more](https://app.codecov.io/gh/apache/datafusion/pull/23832?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #23832 +/- ##
==========================================
- Coverage 80.75% 80.62% -0.14%
==========================================
Files 1089 1090 +1
Lines 368948 370950 +2002
Branches 368948 370950 +2002
==========================================
+ Hits 297952 299075 +1123
- Misses 53237 54009 +772
- Partials 17759 17866 +107
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/23832?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23832:
URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5055242283
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion v54.1.0 (current)
Built [ 108.004s] (current)
Parsing datafusion v54.1.0 (current)
Parsed [ 0.037s] (current)
Building datafusion v54.1.0 (baseline)
Built [ 105.946s] (baseline)
Parsing datafusion v54.1.0 (baseline)
Parsed [ 0.037s] (baseline)
Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.957s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 216.602s] datafusion
Building datafusion-expr v54.1.0 (current)
Built [ 26.360s] (current)
Parsing datafusion-expr v54.1.0 (current)
Parsed [ 0.080s] (current)
Building datafusion-expr v54.1.0 (baseline)
Built [ 25.943s] (baseline)
Parsing datafusion-expr v54.1.0 (baseline)
Parsed [ 0.081s] (baseline)
Checking datafusion-expr v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 1.881s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/enum_variant_added.ron
Failed in:
variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:245
variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:245
--- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum ---
Description:
A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order.
ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/partial_ord_enum_variants_reordered.ron
Failed in:
LogicalPlan::Repartition moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:249
LogicalPlan::Union moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:253
LogicalPlan::TableScan moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:256
LogicalPlan::EmptyRelation moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:260
LogicalPlan::Subquery moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:263
LogicalPlan::SubqueryAlias moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:265
LogicalPlan::Limit moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:267
LogicalPlan::Statement moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:269
LogicalPlan::Values moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:274
LogicalPlan::Explain moved from position 16 to 17, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:277
LogicalPlan::Analyze moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:281
LogicalPlan::Extension moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:284
LogicalPlan::Distinct moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:287
LogicalPlan::Dml moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:289
LogicalPlan::Ddl moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:291
LogicalPlan::Copy moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:293
LogicalPlan::DescribeTable moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:296
LogicalPlan::Unnest moved from position 24 to 25, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:299
LogicalPlan::RecursiveQuery moved from position 25 to 26, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301
LogicalPlan::Repartition moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:249
LogicalPlan::Union moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:253
LogicalPlan::TableScan moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:256
LogicalPlan::EmptyRelation moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:260
LogicalPlan::Subquery moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:263
LogicalPlan::SubqueryAlias moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:265
LogicalPlan::Limit moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:267
LogicalPlan::Statement moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:269
LogicalPlan::Values moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:274
LogicalPlan::Explain moved from position 16 to 17, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:277
LogicalPlan::Analyze moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:281
LogicalPlan::Extension moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:284
LogicalPlan::Distinct moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:287
LogicalPlan::Dml moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:289
LogicalPlan::Ddl moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:291
LogicalPlan::Copy moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:293
LogicalPlan::DescribeTable moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:296
LogicalPlan::Unnest moved from position 24 to 25, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:299
LogicalPlan::RecursiveQuery moved from position 25 to 26, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301
Summary semver requires new major version: 1 major and 0 minor checks failed
Warning produced 1 major and 0 minor level warnings
Finished [ 55.706s] datafusion-expr
Building datafusion-optimizer v54.1.0 (current)
Built [ 25.918s] (current)
Parsing datafusion-optimizer v54.1.0 (current)
Parsed [ 0.033s] (current)
Building datafusion-optimizer v54.1.0 (baseline)
Built [ 25.882s] (baseline)
Parsing datafusion-optimizer v54.1.0 (baseline)
Parsed [ 0.032s] (baseline)
Checking datafusion-optimizer v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.219s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 53.017s] datafusion-optimizer
Building datafusion-physical-plan v54.1.0 (current)
Built [ 35.887s] (current)
Parsing datafusion-physical-plan v54.1.0 (current)
Parsed [ 0.166s] (current)
Building datafusion-physical-plan v54.1.0 (baseline)
Built [ 35.293s] (baseline)
Parsing datafusion-physical-plan v54.1.0 (baseline)
Parsed [ 0.152s] (baseline)
Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.954s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 73.922s] datafusion-physical-plan
Building datafusion-proto v54.1.0 (current)
Built [ 59.413s] (current)
Parsing datafusion-proto v54.1.0 (current)
Parsed [ 0.020s] (current)
Building datafusion-proto v54.1.0 (baseline)
Built [ 58.492s] (baseline)
Parsing datafusion-proto v54.1.0 (baseline)
Parsed [ 0.021s] (baseline)
Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.342s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 120.085s] datafusion-proto
Building datafusion-proto-models v54.1.0 (current)
Built [ 23.697s] (current)
Parsing datafusion-proto-models v54.1.0 (current)
Parsed [ 0.138s] (current)
Building datafusion-proto-models v54.1.0 (baseline)
Built [ 23.573s] (baseline)
Parsing datafusion-proto-models v54.1.0 (baseline)
Parsed [ 0.136s] (baseline)
Checking datafusion-proto-models v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 2.326s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/enum_variant_added.ron
Failed in:
variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83
variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83
variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1407
variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1407
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 51.369s] datafusion-proto-models
Building datafusion-sql v54.1.0 (current)
Built [ 40.231s] (current)
Parsing datafusion-sql v54.1.0 (current)
Parsed [ 0.032s] (current)
Building datafusion-sql v54.1.0 (baseline)
Built [ 40.179s] (baseline)
Parsing datafusion-sql v54.1.0 (baseline)
Parsed [ 0.032s] (baseline)
Checking datafusion-sql v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.376s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 81.948s] datafusion-sql
Building datafusion-substrait v54.1.0 (current)
Built [ 325.604s] (current)
Parsing datafusion-substrait v54.1.0 (current)
Parsed [ 0.019s] (current)
Building datafusion-substrait v54.1.0 (baseline)
Built [ 328.588s] (baseline)
Parsing datafusion-substrait v54.1.0 (baseline)
Parsed [ 0.019s] (baseline)
Checking datafusion-substrait v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.289s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 657.148s] datafusion-substrait
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #23832:
URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5643205287
Thank you @jayzhan211 for the review. I have updated this PR and fired https://github.com/apache/datafusion/pull/25214 🤓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #23832:
URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5633045729
@2010YOUY01 & @jayzhan211, let's go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: serialize ASOF join plans [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 merged PR #23832:
URL: https://github.com/apache/datafusion/pull/23832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org