You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/08/20 11:26:46 UTC
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10304: NRF53: fix broken rptun
pkarashchenko commented on code in PR #10304:
URL: https://github.com/apache/nuttx/pull/10304#discussion_r1299359909
##########
boards/arm/nrf53/nrf5340-dk/scripts/flash_app.ld:
##########
@@ -30,6 +30,7 @@ MEMORY
{
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
+ shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
Review Comment:
```suggestion
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
```
##########
arch/arm/src/nrf53/nrf53_spu.h:
##########
@@ -0,0 +1,55 @@
+/****************************************************************************
+ * arch/arm/src/nrf53/nrf53_spu.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_ARM_SRC_NRF53_NRF53_SPU_H
+#define __ARCH_ARM_SRC_NRF53_NRF53_SPU_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* SPU only for secure app core image */
+
+#if defined(CONFIG_NRF53_APPCORE) && \
Review Comment:
```suggestion
#if defined(CONFIG_NRF53_APPCORE) && \
```
##########
boards/arm/nrf53/thingy53/scripts/flash_app.ld:
##########
@@ -30,6 +30,7 @@ MEMORY
{
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
+ shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
Review Comment:
```suggestion
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
```
##########
boards/arm/nrf53/common/scripts/flash_app.ld:
##########
@@ -53,6 +53,7 @@ MEMORY
LENGTH = FLASH_IMG_SIZE
datamem (rwx) : ORIGIN = RAM_CPUAPP_START_ADDR,
LENGTH = CONFIG_NRF53_CPUAPP_MEM_RAM_SIZE - RPTUN_SHMEM
+ shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
Review Comment:
```suggestion
datamem (rwx) : ORIGIN = RAM_CPUAPP_START_ADDR,
LENGTH = CONFIG_NRF53_CPUAPP_MEM_RAM_SIZE - RPTUN_SHMEM
shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
```
##########
boards/arm/nrf53/nrf5340-audio-dk/scripts/flash_app.ld:
##########
@@ -30,6 +30,7 @@ MEMORY
{
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
+ shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
Review Comment:
```suggestion
progmem (rx) : ORIGIN = 0x00000000, LENGTH = 1024K
datamem (rwx) : ORIGIN = 0x20000000, LENGTH = 512K - RPTUN_SHMEM
shmem (rw) : ORIGIN = 0x20078000, LENGTH = RPTUN_SHMEM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org