You are viewing a plain text version of this content. The canonical link for it is here.

Posted to cvs@httpd.apache.org by mi...@apache.org on 2013/05/15 17:05:28 UTC

svn commit: r1482883 - /httpd/httpd/trunk/modules/proxy/mod_serf.c

Author: minfrin
Date: Wed May 15 15:05:28 2013
New Revision: 1482883

URL: http://svn.apache.org/r1482883
Log:
mod_serf: Add a FIXME, we are using ap_get_client_block() incorrectly.

Modified:
    httpd/httpd/trunk/modules/proxy/mod_serf.c

Modified: httpd/httpd/trunk/modules/proxy/mod_serf.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_serf.c?rev=1482883&r1=1482882&r2=1482883&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_serf.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_serf.c Wed May 15 15:05:28 2013
@@ -539,6 +539,7 @@ static int drive_serf(request_rec *r, se
 
         do {
             len = sizeof(buf);
+            /* FIXME: ap_get_client_block() returns long, not apr_status_t */
             rv = ap_get_client_block(baton->r, buf, len);
             if (rv > 0) {
                 rv = apr_file_write_full(fp, buf, rv, NULL);