You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Julia (JIRA)" <ji...@apache.org> on 2015/05/16 09:36:59 UTC

[jira] [Updated] (REEF-329) Properly use Tag Injection in Group Communication

     [ https://issues.apache.org/jira/browse/REEF-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julia updated REEF-329:
-----------------------
    Description: 
1. Currently in GroupCommClient and CommunicationGroupClient, injectors are created for each group and each operator. BindVolatileParameter is used in many places to achieve object sharing in stead of leverage Tang nature. Fork injection should be properly used in those cases.
2. Besides, Operators are bound at driver side, but the configuration is not used at task side. Instead, clients have to explicitly call methods to get operator instance from CommunicationGroupClient because the complexity to handle generic in injecting operators in Tang. We should properly use Tang to inject Operators with generic argument in CommunicationGroupClient.
3. As operators are created later, therefore the registration of handlers for each operator is also postponed, resulting in race condition. When messages are received, the handler may not be registered yet. Current work round is to sleep and wait. If we can inject operators in CommunicationGroupClient constructor, we would be able to guarantee the handlers are registered before receiving messages. 

  was:
1. Currently in GroupCommClient and CommunicationGroupClient, injectors are created for each group and each operator. BindVolatileParameter is used in many places to achieve object sharing in stead of leverage Tang nature. 
2. Besides, Operators are bound at driver side, but the binding is not used at task side. Instead, clients have to explicitly call method to get operator instance from CommunicationGroupClient because the complexity to handle generic in injecting operators in Tang. 
3. As operators are created later, therefore the registration of handlers for each operator is also postponed, resulting in race condition. When messages are received, the handler may not be registered yet. Current work round is to sleep and wait. If we can inject operators in CommunicationGroupClient constructor, we would be able to guarantee the handlers are registered before receiving messages. 


> Properly use Tag Injection in Group Communication
> -------------------------------------------------
>
>                 Key: REEF-329
>                 URL: https://issues.apache.org/jira/browse/REEF-329
>             Project: REEF
>          Issue Type: Improvement
>            Reporter: Julia
>            Assignee: Julia
>
> 1. Currently in GroupCommClient and CommunicationGroupClient, injectors are created for each group and each operator. BindVolatileParameter is used in many places to achieve object sharing in stead of leverage Tang nature. Fork injection should be properly used in those cases.
> 2. Besides, Operators are bound at driver side, but the configuration is not used at task side. Instead, clients have to explicitly call methods to get operator instance from CommunicationGroupClient because the complexity to handle generic in injecting operators in Tang. We should properly use Tang to inject Operators with generic argument in CommunicationGroupClient.
> 3. As operators are created later, therefore the registration of handlers for each operator is also postponed, resulting in race condition. When messages are received, the handler may not be registered yet. Current work round is to sleep and wait. If we can inject operators in CommunicationGroupClient constructor, we would be able to guarantee the handlers are registered before receiving messages. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)