[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates

[GitBox <gi...@apache.org>]

junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates
URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342134180
 
 
   Probably, it's incomplete. I guess that your OS is Windows. Tests would fail in Linux if the changes are added.
   
   BTW, we should remove the license header of utf8.xml [1] because we get an error. (It should be excluded from rat)
   ```
   Testcase: testUTF8(org.netbeans.modules.templates.SCFTHandlerTest):	Caused an ERROR
   class.txt:1:0 Expected an operand but found <
   <!--
   ^ in class.txt at line number 1 at column number 0 Log:
   ```
   
   [1] https://github.com/apache/incubator-netbeans/blob/master/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
   
   @JaroslavTulach @jlahoda 
   Should we consider Windows in tests?
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services