You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 06:16:03 UTC
[GitHub] [flink] docete opened a new pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
docete opened a new pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877
…the precision when casting timestamp to varchar
## What is the purpose of the change
According to SQL 2011 Part 2 Section 6.13 General Rules 11) d)
> If SD is a datetime data type or an interval data type then let Y be the shortest character string that
> conforms to the definition of <literal> in Subclause 5.3, “<literal>”, and such that the interpreted value of Y is SV and the interpreted precision of Y is the precision of SD.
This PR padding the TIMESTAMP type to respect the precision when casting timestamp to varchar.
## Brief change log
- c53d150 Padding TIMESTAMP type to respect precision
## Verifying this change
This change is already covered by existing tests, such as *TempralTypeTests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575481916
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 (Fri Jan 17 06:19:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145716799 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
* 8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145716799) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r369422152
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/MapTypeTest.scala
##########
@@ -85,13 +85,14 @@ class MapTypeTest extends MapTypeTestBase {
"MAP[DATE '1985-04-11', TIME '14:15:16', DATE '2018-07-26', TIME '17:18:19']",
"{1985-04-11=14:15:16, 2018-07-26=17:18:19}")
- testAllApis(
+ testTableApi(
map(valueLiteral(gLocalTime("14:15:16")), valueLiteral(localDateTime("1985-04-11 14:15:16")),
valueLiteral(gLocalTime("17:18:19")), valueLiteral(localDateTime("2018-07-26 17:18:19"))),
- "map('14:15:16'.toTime, '1985-04-11 14:15:16'.toTimestamp, " +
- "'17:18:19'.toTime, '2018-07-26 17:18:19'.toTimestamp)",
+ "{14:15:16=1985-04-11 14:15:16, 17:18:19=2018-07-26 17:18:19}")
+
+ testSqlApi(
"MAP[TIME '14:15:16', TIMESTAMP '1985-04-11 14:15:16', " +
- "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
+ "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
Review comment:
Currently toTimestamp in Table API can't align to Timestamp literal, because it use `SqlTimeTypeInfo.TIMESTAMP` as the target type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r369509790
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -795,8 +794,8 @@ class TemporalTypesTest extends ExpressionTestBase {
def testTemporalShanghai(): Unit = {
config.setLocalTimeZone(ZoneId.of("Asia/Shanghai"))
- testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123")
- testSqlApi(timestampTz("2018-03-14 19:00:00.010"), "2018-03-14 19:00:00.01")
+ testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123000")
Review comment:
I mean we should improve `timestampTz` to convert timestamp without precision loss.
```scala
private def timestampTz(str: String) = {
val precision = extractPrecision(str)
s"CAST(TIMESTAMP '$str' AS TIMESTAMP($precision) WITH LOCAL TIME ZONE)"
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145716799 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
* 8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145716799) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145716799 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567 TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
* 8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145716799) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4567)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:8f78bcd8f8e6717fe2217825137706c2fbfa5da8 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8f78bcd8f8e6717fe2217825137706c2fbfa5da8
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
* 8f78bcd8f8e6717fe2217825137706c2fbfa5da8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r368274502
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -795,8 +794,8 @@ class TemporalTypesTest extends ExpressionTestBase {
def testTemporalShanghai(): Unit = {
config.setLocalTimeZone(ZoneId.of("Asia/Shanghai"))
- testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123")
- testSqlApi(timestampTz("2018-03-14 19:00:00.010"), "2018-03-14 19:00:00.01")
+ testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123000")
Review comment:
Currently, we don't have a way to construct TIMESTAMP WITH LOCAL TIME ZONE literal. `timestampTz` will lose the original timestamp literal precision and use a default 6 precision. The tests are counter-intuitive because we are padding zeros for a timestamp literal.
Could we improve the `timestampTz` a little bit? It can extract precision from the literal string, and cast to the local timestamp with the extracted precison.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r369941905
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/MapTypeTest.scala
##########
@@ -85,13 +85,14 @@ class MapTypeTest extends MapTypeTestBase {
"MAP[DATE '1985-04-11', TIME '14:15:16', DATE '2018-07-26', TIME '17:18:19']",
"{1985-04-11=14:15:16, 2018-07-26=17:18:19}")
- testAllApis(
+ testTableApi(
map(valueLiteral(gLocalTime("14:15:16")), valueLiteral(localDateTime("1985-04-11 14:15:16")),
valueLiteral(gLocalTime("17:18:19")), valueLiteral(localDateTime("2018-07-26 17:18:19"))),
- "map('14:15:16'.toTime, '1985-04-11 14:15:16'.toTimestamp, " +
- "'17:18:19'.toTime, '2018-07-26 17:18:19'.toTimestamp)",
+ "{14:15:16=1985-04-11 14:15:16, 17:18:19=2018-07-26 17:18:19}")
+
+ testSqlApi(
"MAP[TIME '14:15:16', TIMESTAMP '1985-04-11 14:15:16', " +
- "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
+ "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
Review comment:
There is no such thing in table API which align to Timestamp literal in SQL. I will add some comments to clarify this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r369941607
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -795,8 +794,8 @@ class TemporalTypesTest extends ExpressionTestBase {
def testTemporalShanghai(): Unit = {
config.setLocalTimeZone(ZoneId.of("Asia/Shanghai"))
- testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123")
- testSqlApi(timestampTz("2018-03-14 19:00:00.010"), "2018-03-14 19:00:00.01")
+ testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123000")
Review comment:
OK, According to SQL standard, for timestamp literal, the length of the second fraction should be the precision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong closed pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r369424568
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -795,8 +794,8 @@ class TemporalTypesTest extends ExpressionTestBase {
def testTemporalShanghai(): Unit = {
config.setLocalTimeZone(ZoneId.of("Asia/Shanghai"))
- testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123")
- testSqlApi(timestampTz("2018-03-14 19:00:00.010"), "2018-03-14 19:00:00.01")
+ testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123000")
Review comment:
`timestampTz(expr)` is a shortcut of `CAST(expr AS TIMESTAMP WITH LOCAL TIME ZONE)`, Do you mean we should provide a builtin UDF to convert TIMESTAMP literal to TIMESTAMP WITH LOCAL TIME ZONE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#discussion_r368274102
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/MapTypeTest.scala
##########
@@ -85,13 +85,14 @@ class MapTypeTest extends MapTypeTestBase {
"MAP[DATE '1985-04-11', TIME '14:15:16', DATE '2018-07-26', TIME '17:18:19']",
"{1985-04-11=14:15:16, 2018-07-26=17:18:19}")
- testAllApis(
+ testTableApi(
map(valueLiteral(gLocalTime("14:15:16")), valueLiteral(localDateTime("1985-04-11 14:15:16")),
valueLiteral(gLocalTime("17:18:19")), valueLiteral(localDateTime("2018-07-26 17:18:19"))),
- "map('14:15:16'.toTime, '1985-04-11 14:15:16'.toTimestamp, " +
- "'17:18:19'.toTime, '2018-07-26 17:18:19'.toTimestamp)",
+ "{14:15:16=1985-04-11 14:15:16, 17:18:19=2018-07-26 17:18:19}")
+
+ testSqlApi(
"MAP[TIME '14:15:16', TIMESTAMP '1985-04-11 14:15:16', " +
- "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
+ "TIME '17:18:19', TIMESTAMP '2018-07-26 17:18:19']",
Review comment:
I find that we have a lot of this changes that remove the `toTimestamp` from the tests.
I'm wondering could we align the `toTimestamp` with the SQL timestmap literal?
Currently `"2018-07-26 17:18:19".toTimestamp` actually calls `"2018-07-26 17:18:19".cast(DataTypes.TIMESTAMP(3))`, however, according to the javadoc of `toTimestamp`, it should be the same with SQL `TIMESTAMP string`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145102193 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
Hash:ce96d1f611a6ffdb77fc51c30fce5715e88065ea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469 TriggerType:PUSH TriggerID:ce96d1f611a6ffdb77fc51c30fce5715e88065ea
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
* ce96d1f611a6ffdb77fc51c30fce5715e88065ea Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145102193) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4469)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10877: [FLINK-15602][table-planner-blink] Padding TIMESTAMP type to respect …
URL: https://github.com/apache/flink/pull/10877#issuecomment-575493649
<!--
Meta data
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144866938 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
Hash:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418 TriggerType:PUSH TriggerID:c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1
-->
## CI report:
* c53d150308c6f08fc6c2d9bd6dd84b36e2021ef1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144866938) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services