You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/09 21:26:37 UTC

[GitHub] [gobblin] htran1 opened a new pull request #3305: [GOBBLIN-1465] Refactor the GobblinOrcWriter to support using a diffe…

htran1 opened a new pull request #3305:
URL: https://github.com/apache/gobblin/pull/3305


   …rent OrcValueWriter
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1465
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   The GobblinOrcWriter uses the GenericRecordToOrcValueWriter and takes in input records as GenericRecords. There may be use cases where the input type is not an Avro GenericRecord, so refactor the code to support extending the writer to support other input types. The bulk of the code in the original GobblinOrcWriter is moved to GobblinBaseOrcWriter.
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   There is an existing GobblinOrcWriterTest test.
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] htran1 commented on pull request #3305: [GOBBLIN-1465] Refactor the GobblinOrcWriter to support using a diffe…

Posted by GitBox <gi...@apache.org>.
htran1 commented on pull request #3305:
URL: https://github.com/apache/gobblin/pull/3305#issuecomment-858176979


   @autumnust, please review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] asfgit closed pull request #3305: [GOBBLIN-1465] Refactor the GobblinOrcWriter to support using a diffe…

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3305:
URL: https://github.com/apache/gobblin/pull/3305


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org