[GitHub] [apisix] tokers commented on a change in pull request #3577: feat: support conditional response rewrite

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #3577:
URL: https://github.com/apache/apisix/pull/3577#discussion_r584015215



##########
File path: doc/plugins/response-rewrite.md
##########
@@ -45,6 +45,7 @@ response rewrite plugin, rewrite the content returned by the upstream as well as
 | body        | string  | optional    |         |            | New `body` to client, and the content-length will be reset too.                                                                                                                                                               |
 | body_base64 | boolean | optional    | false   |            | Identify if `body` in configuration need base64 decoded before rewrite to client.                                                                                                                                             |
 | headers     | object  | optional    |         |            | Set the new `headers` for client, can set up multiple. If it exists already from upstream, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header. |
+| vars     | array[]  | optional    |         |            | A DSL to evaluate with the given ngx.var. See `vars` [lua-resty-expr](https://github.com/api7/lua-resty-expr#operator-list). |

Review comment:
       Should mention here that "if `vars` is absent, rewrite operations will be executed unconditionally".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org