You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:36:24 UTC
[GitHub] [flink] wujinhu opened a new pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
wujinhu opened a new pull request #19072:
URL: https://github.com/apache/flink/pull/19072
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
OSS offers persistence only after uploads or multi-part uploads complete. In order to make streaming uses OSS as sink, we should implement a Recoverable writer. This writer will snapshot and store multi-part upload information and recover from those information when failure occurs.
## Brief change log
**- move utility classes to flink-fs-common**
**- add abstract test classes for recoverable writers(s3/oss)**
**- add OSS recoverable writer**
## Verifying this change
This implementation adds some tests to test logic of recoverable writer. However, in order to run these tests, someone need to have his own Aliyun access key id and access key secret. Then, set environment variables below：
`export ARTIFACTS_OSS_ENDPOINT=<Aliyun OSS endpoint to connect to>`
`export ARTIFACTS_OSS_BUCKET=<Your bucket>`
`export ARTIFACTS_OSS_ACCESS_KEY=<Your access key id>`
`export ARTIFACTS_OSS_SECRET_KEY=<Your access secret>`
These tests are skipped by default.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993)
* ea43c4a319f7357ecab4c918755255f989a2e20a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #19072:
URL: https://github.com/apache/flink/pull/19072#discussion_r827599320
##########
File path: flink-filesystems/flink-fs-common/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <artifactId>flink-filesystems</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-fs-common</artifactId>
Review comment:
I think we can just move utils to `flink-core` just like `RefCountedFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "1075796098",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1068703763
You can create a JIRA for updating document in: https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/connectors/datastream/filesystem/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #19072:
URL: https://github.com/apache/flink/pull/19072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #19072:
URL: https://github.com/apache/flink/pull/19072#discussion_r828712150
##########
File path: flink-filesystems/flink-oss-fs-hadoop/src/main/java/org/apache/flink/fs/osshadoop/OSSAccessor.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.fs.osshadoop;
+
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.runtime.fs.hdfs.HadoopFileSystem;
+
+import com.aliyun.oss.model.CompleteMultipartUploadResult;
+import com.aliyun.oss.model.PartETag;
+import org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem;
+import org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystemStore;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Core implementation of Aliyun OSS Filesystem for Flink. Provides the bridging logic between
+ * Hadoop's abstract filesystem and Aliyun OSS.
+ */
+public class OSSAccessor {
+
+ private AliyunOSSFileSystem fs;
+ private AliyunOSSFileSystemStore store;
+
+ public OSSAccessor(AliyunOSSFileSystem fs) {
+ this.fs = fs;
+ this.store = fs.getStore();
+ }
+
+ public String pathToObject(final Path path) {
+ org.apache.hadoop.fs.Path hadoopPath = HadoopFileSystem.toHadoopPath(path);
+ if (!hadoopPath.isAbsolute()) {
+ hadoopPath = new org.apache.hadoop.fs.Path(fs.getWorkingDirectory(), hadoopPath);
+ }
+
+ return hadoopPath.toUri().getPath().substring(1);
+ }
+
+ public Path objectToPath(String object) {
+ return new Path("/" + object);
+ }
+
+ public String startMultipartUpload(String objectName) {
+ return store.getUploadId(objectName);
+ }
+
+ public boolean deleteObject(String objectName) throws IOException {
+ return fs.delete(new org.apache.hadoop.fs.Path('/' + objectName), false);
+ }
+
+ public CompleteMultipartUploadResult completeMultipartUpload(
+ String objectName, String uploadId, List<PartETag> partETags) {
+ return store.completeMultipartUpload(objectName, uploadId, partETags);
+ }
+
+ public PartETag uploadPart(File file, String objectName, String uploadId, int idx)
+ throws IOException {
+ return store.uploadPart(file, objectName, uploadId, idx);
+ }
+
+ public void putObject(String objectName, File file) throws IOException {
+ store.uploadObject(objectName, file);
+ }
+
+ public void getObject(String objectName, String dstPath, long length) throws IOException {
+ long contentLength = store.getObjectMetadata(objectName).getContentLength();
+ if (contentLength != length) {
+ throw new IOException(
+ String.format(
+ "Error recovering writer: "
+ + "Downloading the last data chunk file gives incorrect length."
+ + "File length is %d bytes, RecoveryData indicates %d bytes",
+ contentLength, length));
+ }
+
+ org.apache.hadoop.fs.Path srcPath = new org.apache.hadoop.fs.Path("/" + objectName);
+ org.apache.hadoop.fs.Path localPath = new org.apache.hadoop.fs.Path(dstPath);
+ fs.copyToLocalFile(srcPath, localPath);
+
+ String crcFileName = "." + localPath.getName() + ".crc";
+ (new File(localPath.getParent().toString() + "/" + crcFileName)).delete();
Review comment:
Remove `()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993)
* ea43c4a319f7357ecab4c918755255f989a2e20a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea43c4a319f7357ecab4c918755255f989a2e20a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569)
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #19072:
URL: https://github.com/apache/flink/pull/19072#discussion_r827599320
##########
File path: flink-filesystems/flink-fs-common/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <artifactId>flink-filesystems</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-fs-common</artifactId>
Review comment:
I think we can just move utils to `flink-core` just like `RefCountedFile`.
You can create a PR to finish the copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066495946
Thanks @wujinhu , I will take a look~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8443aa222a50968116dc740c7cd79ce8a518a72 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993)
* ea43c4a319f7357ecab4c918755255f989a2e20a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569)
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "1075796098",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wujinhu commented on a change in pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
wujinhu commented on a change in pull request #19072:
URL: https://github.com/apache/flink/pull/19072#discussion_r829640298
##########
File path: flink-filesystems/flink-fs-common/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <artifactId>flink-filesystems</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-fs-common</artifactId>
Review comment:
Ok, it seems good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wujinhu commented on a change in pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
wujinhu commented on a change in pull request #19072:
URL: https://github.com/apache/flink/pull/19072#discussion_r829640298
##########
File path: flink-filesystems/flink-fs-common/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <artifactId>flink-filesystems</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-fs-common</artifactId>
Review comment:
Ok, it seems good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1066471341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32993",
"triggerID" : "a8443aa222a50968116dc740c7cd79ce8a518a72",
"triggerType" : "PUSH"
}, {
"hash" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33569",
"triggerID" : "ea43c4a319f7357ecab4c918755255f989a2e20a",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"triggerType" : "PUSH"
}, {
"hash" : "5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580",
"triggerID" : "1075796098",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5715ca8ed70256fb4c1f9303a2e7b04d1b8d8ebd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wujinhu commented on pull request #19072: [FLINK-11388][fs] Add Aliyun OSS recoverable writer
Posted by GitBox <gi...@apache.org>.
wujinhu commented on pull request #19072:
URL: https://github.com/apache/flink/pull/19072#issuecomment-1075796098
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org