You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org> on 2007/03/03 15:14:50 UTC

[jira] Created: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

XmlPullParser does not respect the XML NameChar syntax
------------------------------------------------------

                 Key: WICKET-350
                 URL: https://issues.apache.org/jira/browse/WICKET-350
             Project: Wicket
          Issue Type: Bug
          Components: wicket
            Reporter: Jean-Baptiste Quenot
         Assigned To: Jean-Baptiste Quenot


This simple test fails:

parser.parse("<filter-mapping>");
XmlTag tag = (XmlTag)parser.nextTag();
assertEquals("filter-mapping", tag.getName());

tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-350.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Fixed in 2.0

> XmlPullParser does not respect the XML NameChar syntax
> ------------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-350) XmlPullParser does not respect the XML NCName syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-350:
----------------------------------------

    Fix Version/s: 1.3

> XmlPullParser does not respect the XML NCName syntax
> ----------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 1.3, 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-350) XmlPullParser does not respect the XML NCName syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-350:
----------------------------------------

    Fix Version/s:     (was: trunk)
                   1.3.0-beta1

> XmlPullParser does not respect the XML NCName syntax
> ----------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>            Assignee: Jean-Baptiste Quenot
>             Fix For: 1.3.0-beta1, 2.0 branch (discontinued)
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-350:
----------------------------------------

    Attachment: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt

> XmlPullParser does not respect the XML NameChar syntax
> ------------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-350) XmlPullParser does not respect the XML NCName syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-350:
----------------------------------------

    Summary: XmlPullParser does not respect the XML NCName syntax  (was: XmlPullParser does not respect the XML NameChar syntax)

> XmlPullParser does not respect the XML NCName syntax
> ----------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477639 ] 

Jean-Baptiste Quenot commented on WICKET-350:
---------------------------------------------

Juergen, why do you close the issue so quickly?  It's not applied to branch 1.x, and its' not even fixed properly in trunk.  Did you see that I attached a patch and that I assigned this issue to myself?  There is not only the hyphen, there is also the dot that is missing.  And naming it VARIABLE_NAME2 is very dubious.

> XmlPullParser does not respect the XML NameChar syntax
> ------------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-350) XmlPullParser does not respect the XML NCName syntax

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477760 ] 

Juergen Donnerstag commented on WICKET-350:
-------------------------------------------

It is just resolved in 2.0 and the changes for 1.x have been committed at the same moment. 
The dot: you'll find that the xml parser is not a general purpose xml parser complying to all details of xml. It doesn't have to. It just implements what is sufficient for Wicket. If only if there is a real need to implement an additional detail, than we'll do it. The dot, though in the spec, is nowhere used. So why bother and implement

> XmlPullParser does not respect the XML NCName syntax
> ----------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477636 ] 

Juergen Donnerstag commented on WICKET-350:
-------------------------------------------

XML_NAME must not contain the colon

> XmlPullParser does not respect the XML NameChar syntax
> ------------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-350) XmlPullParser does not respect the XML NameChar syntax

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-350:
----------------------------------------

    Attachment: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt

Updated patch, NCNameChar does not have the ":" sign

See http://www.w3.org/TR/REC-xml-names/#NT-QName

> XmlPullParser does not respect the XML NameChar syntax
> ------------------------------------------------------
>
>                 Key: WICKET-350
>                 URL: https://issues.apache.org/jira/browse/WICKET-350
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 2.0
>
>         Attachments: 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt, 20070303-wicket-1.x-WICKET-350-XmlPullParser.txt
>
>
> This simple test fails:
> parser.parse("<filter-mapping>");
> XmlTag tag = (XmlTag)parser.nextTag();
> assertEquals("filter-mapping", tag.getName());
> tag.getName() returns "filter".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.