You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mugdha Varadkar <mu...@gmail.com> on 2023/04/03 07:30:34 UTC
Re: Review Request 74352: RANGER-4138 Build ranger-react UI and backbone UI code base in webapp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74352/
-----------------------------------------------------------
(Updated April 3, 2023, 7:30 a.m.)
Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Nikunj Pansuriya, and Velmurugan Periasamy.
Bugs: RANGER-4138
https://issues.apache.org/jira/browse/RANGER-4138
Repository: ranger
Description
-------
This review is tracking changes to build ranger-react and backbone code base into webapp directory of Ranger Admin.
With this change, by default Ranger Admin UI with react code base will get loaded. If user want to view Ranger Admin UI with backbone code base, they will get a option in the Top User Profile section as - "Backbone Classic UI".
Removing the profiles security-admin-react and security-admin-backbone used to build react and backbone respectively.
No need to pass -Psecurity-admin-react profile option to mvn command to build Ranger Admin code base with react.
Diffs (updated)
-----
security-admin/pom.xml 2e5e21950afe751fa6bf55f0d4f8b7f229a3d928
security-admin/src/main/webapp/index.html
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx 5d3f26ae8035820826e22a6c35ebdc82b20b3905
security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 87e4dca27733a3bb48c95d4dbd7519d9faa52f55
security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html d8c2112f11d6a434645411d72b007901178dbc5f
Diff: https://reviews.apache.org/r/74352/diff/2/
Changes: https://reviews.apache.org/r/74352/diff/1-2/
Testing
-------
Build ranger using below command and setup a local cluster,
mvn clean compile package -DskipTest
Thanks,
Mugdha Varadkar
Re: Review Request 74352: RANGER-4138 Build ranger-react UI and backbone UI code base in webapp
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74352/#review225897
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 27, 2023, 5:57 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74352/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2023, 5:57 a.m.)
>
>
> Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Nikunj Pansuriya, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4138
> https://issues.apache.org/jira/browse/RANGER-4138
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This review is tracking changes to build ranger-react and backbone code base into webapp directory of Ranger Admin.
>
> With this change, by default Ranger Admin UI with react code base will get loaded. If user want to view Ranger Admin UI with backbone code base, they will get a option in the Top User Profile section as - "Backbone Classic UI".
>
> Removing the profiles security-admin-react and security-admin-backbone used to build react and backbone respectively.
>
> No need to pass -Psecurity-admin-react profile option to mvn command to build Ranger Admin code base with react.
>
>
> Diffs
> -----
>
> security-admin/pom.xml 08d289590b3a49c4170c22e040821a65f1869c7e
> security-admin/src/main/webapp/index.html
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx 65a0414bca68e27d31af06a179a7818353f6047d
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx a654548a292f9379754f248ba6cb54e495e89885
> security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 87e4dca27733a3bb48c95d4dbd7519d9faa52f55
> security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html d8c2112f11d6a434645411d72b007901178dbc5f
>
>
> Diff: https://reviews.apache.org/r/74352/diff/3/
>
>
> Testing
> -------
>
> Build ranger using below command and setup a local cluster,
>
> mvn clean compile package -DskipTest
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 74352: RANGER-4138 Build ranger-react UI and backbone UI code base in webapp
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74352/
-----------------------------------------------------------
(Updated Oct. 27, 2023, 5:57 a.m.)
Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Nikunj Pansuriya, and Velmurugan Periasamy.
Bugs: RANGER-4138
https://issues.apache.org/jira/browse/RANGER-4138
Repository: ranger
Description
-------
This review is tracking changes to build ranger-react and backbone code base into webapp directory of Ranger Admin.
With this change, by default Ranger Admin UI with react code base will get loaded. If user want to view Ranger Admin UI with backbone code base, they will get a option in the Top User Profile section as - "Backbone Classic UI".
Removing the profiles security-admin-react and security-admin-backbone used to build react and backbone respectively.
No need to pass -Psecurity-admin-react profile option to mvn command to build Ranger Admin code base with react.
Diffs (updated)
-----
security-admin/pom.xml 08d289590b3a49c4170c22e040821a65f1869c7e
security-admin/src/main/webapp/index.html
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx 65a0414bca68e27d31af06a179a7818353f6047d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx a654548a292f9379754f248ba6cb54e495e89885
security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 87e4dca27733a3bb48c95d4dbd7519d9faa52f55
security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html d8c2112f11d6a434645411d72b007901178dbc5f
Diff: https://reviews.apache.org/r/74352/diff/3/
Changes: https://reviews.apache.org/r/74352/diff/2-3/
Testing
-------
Build ranger using below command and setup a local cluster,
mvn clean compile package -DskipTest
Thanks,
Mugdha Varadkar