You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "ariesdevil (via GitHub)" <gi...@apache.org> on 2026/08/02 12:46:52 UTC

[PR] refactor(theta_family): reorganize theta family mods and add key-only sketch views (datasketches-rust)

ariesdevil opened a new pull request, #178:
URL: https://github.com/apache/datasketches-rust/pull/178

   ## Summary
   
   - Group the shared Theta, Theta, and Tuple implementations under `theta_family`.
     - Preserve the existing public module paths through re-exports.
   - Introduce key-only sketch views for operations that only consume retained hashes.
     - Update Jaccard similarity and the B side of A-not-B to avoid cloning Tuple summaries.
     - Keep full retained-entry views for operations such as union and intersection.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [PR] refactor: reorganize theta family mods and add key-only sketch views (datasketches-rust)

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #178:
URL: https://github.com/apache/datasketches-rust/pull/178#issuecomment-5160071749

   I pushed https://github.com/apache/datasketches-rust/pull/179 to rename `theta_family` to `thetafamily`. It's not exported so it makes no difference from user interfaces, but keep our top-level modules no separator which provides a stable style (my bias, yes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [PR] refactor: reorganize theta family mods and add key-only sketch views (datasketches-rust)

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #178:
URL: https://github.com/apache/datasketches-rust/pull/178#issuecomment-5159278448

   Now I know you use a `theta_family` mod to keep several methods `pub(super)`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [PR] refactor: reorganize theta family mods and add key-only sketch views (datasketches-rust)

Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil commented on PR #178:
URL: https://github.com/apache/datasketches-rust/pull/178#issuecomment-5162113137

   > But I'd still prefer:
   > 
   > ```
   > theta
   > thetacommon
   > tuple
   > ```
   > 
   > .. structure.
   
   Actually, I like the original structure too, but I don't want to put `thetacommon` at the top level, so I came up with a compromise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [PR] refactor: reorganize theta family mods and add key-only sketch views (datasketches-rust)

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #178:
URL: https://github.com/apache/datasketches-rust/pull/178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org