You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/20 10:32:42 UTC
Review Request 62434: Fixed horizontal ellipsis in Web UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7978
https://issues.apache.org/jira/browse/MESOS-7978
Repository: mesos
Description
-------
We were previously using non-printable characters which
is an issue for the JavaScript linter we plan to use.
Diffs
-----
src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
Diff: https://reviews.apache.org/r/62434/diff/1/
Testing
-------
Change in the UI tested with Google Chrome 61.0.3163.91.
Thanks,
Armand Grillet
Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185789
-----------------------------------------------------------
PASS: Mesos patch 62434 was successfully built and tested.
Reviews applied: `['62434']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62434
- Mesos Reviewbot Windows
On Sept. 20, 2017, 4:02 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 4:02 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were previously using non-printable characters which
> is an issue for the JavaScript linter we plan to use.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
>
>
> Diff: https://reviews.apache.org/r/62434/diff/1/
>
>
> Testing
> -------
>
> Change in the UI tested with Google Chrome 61.0.3163.91.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Sept. 21, 2017, 7:42 p.m., Benjamin Mahler wrote:
> > I can't tell from the testing section, but I'll assume that you tested this by starting an agent and looking at it's ID. If not, can you please do so and follow up if there's an issue?
Also, the commit title seems to indicate there was an issue here, how about:
```
Fixed a javascript lint issue related to ellipsis in the webui.
```
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185915
-----------------------------------------------------------
On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 10:32 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were previously using non-printable characters which
> is an issue for the JavaScript linter we plan to use.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
>
>
> Diff: https://reviews.apache.org/r/62434/diff/1/
>
>
> Testing
> -------
>
> Change in the UI tested with Google Chrome 61.0.3163.91.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185915
-----------------------------------------------------------
Fix it, then Ship it!
I can't tell from the testing section, but I'll assume that you tested this by starting an agent and looking at it's ID. If not, can you please do so and follow up if there's an issue?
src/webui/master/static/js/app.js
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/62434/#comment262253>
It's a little less clear what this is doing now, how about a comment?
An example for agent id is:
9d4b2f2b-a759-4458-bebf-7d3507a6f0ca-S9
...bebf-7d3507a6f0ca-S9
// Returns a truncated ID, for example:
// Input: 9d4b2f2b-a759-4458-bebf-7d3507a6f0ca-S9
// Output: ...bebf-7d3507a6f0ca-S9
//
// Note that an ellipsis is used for display purposes.
- Benjamin Mahler
On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 10:32 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were previously using non-printable characters which
> is an issue for the JavaScript linter we plan to use.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
>
>
> Diff: https://reviews.apache.org/r/62434/diff/1/
>
>
> Testing
> -------
>
> Change in the UI tested with Google Chrome 61.0.3163.91.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185841
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62434]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 10:32 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were previously using non-printable characters which
> is an issue for the JavaScript linter we plan to use.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
>
>
> Diff: https://reviews.apache.org/r/62434/diff/1/
>
>
> Testing
> -------
>
> Change in the UI tested with Google Chrome 61.0.3163.91.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185842
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 10:32 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were previously using non-printable characters which
> is an issue for the JavaScript linter we plan to use.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce
>
>
> Diff: https://reviews.apache.org/r/62434/diff/1/
>
>
> Testing
> -------
>
> Change in the UI tested with Google Chrome 61.0.3163.91.
>
>
> Thanks,
>
> Armand Grillet
>
>