You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/10/21 15:28:15 UTC

[doris] branch master updated: [fix](plugin) bugfix for dirty uninstallation of dynamic plugin (#13540) (#13543)

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 60e9fe2b3a [fix](plugin) bugfix for dirty uninstallation of dynamic plugin (#13540) (#13543)
60e9fe2b3a is described below

commit 60e9fe2b3a0afd501a39b1f21755a54b8b664346
Author: wxy <du...@gmail.com>
AuthorDate: Fri Oct 21 23:28:06 2022 +0800

    [fix](plugin) bugfix for dirty uninstallation of dynamic plugin (#13540) (#13543)
    
    Co-authored-by: wangxiangyu@360shuke.com <wa...@360shuke.com>
---
 .../java/org/apache/doris/plugin/DynamicPluginLoader.java     | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/plugin/DynamicPluginLoader.java b/fe/fe-core/src/main/java/org/apache/doris/plugin/DynamicPluginLoader.java
index e988a8697b..2a9e3f28a8 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/plugin/DynamicPluginLoader.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/plugin/DynamicPluginLoader.java
@@ -112,14 +112,15 @@ public class DynamicPluginLoader extends PluginLoader {
 
         movePlugin();
 
-        plugin = dynamicLoadPlugin(true);
+        try {
+            plugin = dynamicLoadPlugin(true);
+
+            pluginInstallValid();
 
-        pluginInstallValid();
+            pluginContext.setPluginPath(installPath.toString());
 
-        pluginContext.setPluginPath(installPath.toString());
-        try {
             plugin.init(pluginInfo, pluginContext);
-        } catch (Error e) {
+        } catch (Throwable e) {
             throw new UserException(e.getMessage());
         }
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org