You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/05 03:08:53 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7593: [FIX] Fix clang12 warnings

tqchen commented on a change in pull request #7593:
URL: https://github.com/apache/tvm/pull/7593#discussion_r588000196



##########
File path: src/runtime/contrib/json/json_runtime.h
##########
@@ -98,7 +98,7 @@ class JSONRuntimeBase : public ModuleNode {
     }
   }
 
-  virtual void SaveToBinary(dmlc::Stream* stream) {
+  void SaveToBinary(dmlc::Stream* stream) override {

Review comment:
       Should be final 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org