You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2026/05/27 07:39:46 UTC
[PR] [improvement](be) Add release-enabled Doris check macros [doris]
mrhhsg opened a new pull request, #63730:
URL: https://github.com/apache/doris/pull/63730
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Add `DORIS_CHECK_EQ/NE/LT/LE/GT/GE` macros for invariants that should remain checked in Release builds. In Debug builds they map to the corresponding `DCHECK_*` macros. In Release builds they evaluate each operand once, compare with the requested operator, and throw through the existing `DORIS_CHECK`-style fatal error path with a message that includes both compared expressions and their actual values.
### Release note
None
### Check List (For Author)
- Test: Manual test
- `ninja -C be/ut_build_ASAN test/CMakeFiles/doris_be_test.dir/common/status_test.cpp.o`
- Compiled a small `-DNDEBUG` translation unit to verify the Release macro branch, including value-printing comparison macros.
- `build-support/check-format.sh`
- Attempted `./run-be-ut.sh --run --filter=StatusTest.*`, but stopped it after it expanded into a broad BE UT rebuild.
- Attempted `build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN --files be/src/common/status.h be/test/common/status_test.cpp`, but it failed on pre-existing/toolchain header diagnostics outside this change.
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4555024786
# BE UT Coverage Report
Increment line coverage `28.89% (13/45)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/4ae57b270c3eea2a933518d7ecf88ac20d1f8b75_4ae57b270c3eea2a933518d7ecf88ac20d1f8b75/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/4ae57b270c3eea2a933518d7ecf88ac20d1f8b75_4ae57b270c3eea2a933518d7ecf88ac20d1f8b75/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.89% (20945/38866) |
| Line Coverage | 37.47% (198495/529738) |
| Region Coverage | 33.78% (155556/460493) |
| Branch Coverage | 34.77% (67719/194768) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4570262449
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4573401602
# BE Regression && UT Coverage Report
Increment line coverage `56.00% (14/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63730_999b95428f53615d701a7bd8464107f32c395296_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63730_999b95428f53615d701a7bd8464107f32c395296_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.84% (28130/38095) |
| Line Coverage | 57.80% (305716/528927) |
| Region Coverage | 54.83% (255203/465431) |
| Branch Coverage | 56.41% (110406/195709) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3322002212
##########
be/src/exprs/function/function_jsonb.cpp:
##########
@@ -2725,7 +2724,7 @@ class FunctionJsonbRemove : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
- DCHECK_GE(arguments.size(), 2);
+ DORIS_CHECK_GE(arguments.size(), 2);
Review Comment:
Correction: the `function_jsonb.cpp` changes are intentional for this PR, so I restored them in the latest head. My previous reply saying this file was restored to the old validation path was incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4552482014
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4570298353
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4552492367
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4572441151
<details>
<summary>TPC-H: <b>Total hot run time: 31999 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 999b95428f53615d701a7bd8464107f32c395296, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17636 4189 4173 4173
q2 q3 10802 1461 832 832
q4 4682 476 344 344
q5 7622 2322 2141 2141
q6 251 178 136 136
q7 919 821 633 633
q8 9424 1930 1628 1628
q9 5201 4972 4988 4972
q10 6419 2210 1878 1878
q11 440 280 245 245
q12 682 426 301 301
q13 18228 3460 2821 2821
q14 268 259 244 244
q15 q16 836 773 711 711
q17 908 974 941 941
q18 7181 5755 5520 5520
q19 1171 1299 1167 1167
q20 573 468 307 307
q21 6236 2926 2679 2679
q22 574 395 326 326
Total cold run time: 100053 ms
Total hot run time: 31999 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4738 4934 4890 4890
q2 q3 4919 5329 4663 4663
q4 2116 2199 1403 1403
q5 4843 5006 4714 4714
q6 241 174 130 130
q7 2006 1796 1548 1548
q8 2503 2233 2240 2233
q9 8174 7729 7524 7524
q10 4782 4721 4197 4197
q11 541 382 352 352
q12 744 736 519 519
q13 3083 3388 2784 2784
q14 268 288 249 249
q15 q16 683 706 611 611
q17 1306 1270 1279 1270
q18 7302 7027 6859 6859
q19 1099 1069 1132 1069
q20 2239 2234 1956 1956
q21 5363 4640 4445 4445
q22 517 494 413 413
Total cold run time: 57467 ms
Total hot run time: 51829 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3322019254
##########
be/src/exprs/function/function_jsonb.cpp:
##########
@@ -2053,7 +2053,6 @@ class FunctionJsonbModify : public IFunction {
replace = true;
if (!build_parents_by_path(json_documents[row_idx]->getValue(),
json_path[path_index], parents)) {
- DCHECK(false);
continue;
}
Review Comment:
This removes the only Debug-time signal for a broken parent-chain invariant. In this branch `find_result.value` was already found for the full path, so `build_parents_by_path(...)` should be able to reconstruct the parent chain; if it cannot, silently continuing skips the requested modification and hides the inconsistency. If the intent is not to change release behavior, please keep the existing `DCHECK(false)` before the `continue` instead of dropping the check.
```suggestion
DCHECK(false);
continue;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4571403453
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3310172531
##########
be/src/exprs/function/function_jsonb.cpp:
##########
@@ -2725,7 +2724,7 @@ class FunctionJsonbRemove : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
- DCHECK_GE(arguments.size(), 2);
+ DORIS_CHECK_GE(arguments.size(), 2);
Review Comment:
This check now fires before the existing validation below, so `json_remove` with fewer than two arguments no longer returns `Status::InvalidArgument("json_remove requires at least 2 arguments")` in Release builds; it throws a fatal check exception instead. Since this function is variadic (`get_number_of_arguments() == 0`, `is_variadic() == true`) and already has a user-facing arity check immediately after this line, the arity failure is not an invariant for `DORIS_CHECK_GE`. Please leave this as a non-fatal validation path, for example by removing this `DORIS_CHECK_GE` and relying on the existing `if (arguments.size() < 2)` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4554449930
<details>
<summary>TPC-H: <b>Total hot run time: 31808 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4ae57b270c3eea2a933518d7ecf88ac20d1f8b75, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17663 4034 3992 3992
q2 q3 10766 1499 825 825
q4 4683 474 344 344
q5 7561 2292 2148 2148
q6 250 176 136 136
q7 963 788 628 628
q8 9365 1739 1675 1675
q9 5531 4983 4940 4940
q10 6447 2217 1889 1889
q11 452 279 247 247
q12 633 426 290 290
q13 18218 3362 2833 2833
q14 271 254 237 237
q15 q16 823 769 713 713
q17 1033 1003 982 982
q18 6946 5828 5530 5530
q19 1305 1233 1162 1162
q20 556 450 285 285
q21 6068 2860 2639 2639
q22 457 504 313 313
Total cold run time: 99991 ms
Total hot run time: 31808 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4801 4738 4754 4738
q2 q3 4923 5284 4617 4617
q4 2179 2155 1402 1402
q5 4974 4744 4665 4665
q6 244 171 124 124
q7 1921 1781 1569 1569
q8 2397 2152 2175 2152
q9 7833 7424 7384 7384
q10 4769 4679 4187 4187
q11 532 378 347 347
q12 727 740 524 524
q13 3010 3401 2813 2813
q14 271 288 252 252
q15 q16 684 717 614 614
q17 1283 1257 1242 1242
q18 7438 7018 6887 6887
q19 1106 1106 1109 1106
q20 2242 2210 1962 1962
q21 5309 4580 4499 4499
q22 525 473 403 403
Total cold run time: 57168 ms
Total hot run time: 51487 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3309509844
##########
be/src/common/check.cpp:
##########
@@ -0,0 +1,29 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "common/check.h"
+
+#include "common/exception.h"
+#include "common/status.h"
+
+namespace doris {
+
+void doris_check_fail(std::string_view message) {
Review Comment:
`message` is already the fully-rendered stream contents, but `Status::FatalError(message)` treats it as a fmt format string in debug builds (`FatalError` calls `fmt::format(msg, ...)` under `#ifndef NDEBUG`). A check like `DORIS_CHECK(false) << "json {";` will throw `fmt::format_error` before the fatal check path/logging, while release builds preserve the literal text. Please pass it as data, e.g. `Status::FatalError("{}", message)`, so streamed braces and other fmt syntax remain literal.
```suggestion
throw Exception(Status::FatalError("{}", message));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3321982276
##########
be/src/exprs/function/function_jsonb.cpp:
##########
@@ -2725,7 +2724,7 @@ class FunctionJsonbRemove : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
- DCHECK_GE(arguments.size(), 2);
+ DORIS_CHECK_GE(arguments.size(), 2);
Review Comment:
Restored `function_jsonb.cpp` so `json_remove` keeps the existing `Status::InvalidArgument` arity validation path. The PR diff is now limited to `common/check.*`, `status.h`, and the new `check_test` coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #63730:
URL: https://github.com/apache/doris/pull/63730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4572187447
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4572531919
<details>
<summary>TPC-DS: <b>Total hot run time: 173129 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 999b95428f53615d701a7bd8464107f32c395296, data reload: false
query5 4322 676 541 541
query6 324 223 208 208
query7 4345 556 315 315
query8 360 245 219 219
query9 8787 4136 4113 4113
query10 486 339 303 303
query11 5753 2403 2262 2262
query12 187 127 127 127
query13 1274 640 456 456
query14 6197 5585 5261 5261
query14_1 4545 4581 4449 4449
query15 212 203 184 184
query16 1026 441 427 427
query17 966 711 579 579
query18 2453 491 356 356
query19 218 197 177 177
query20 133 132 130 130
query21 216 141 119 119
query22 13722 13554 13417 13417
query23 17454 16698 16242 16242
query23_1 16392 16326 16238 16238
query24 7494 1758 1333 1333
query24_1 1266 1312 1317 1312
query25 549 484 417 417
query26 1310 327 176 176
query27 2694 562 356 356
query28 4530 2035 1999 1999
query29 987 615 505 505
query30 299 239 198 198
query31 1146 1097 963 963
query32 97 79 76 76
query33 551 373 308 308
query34 1204 1156 657 657
query35 791 815 720 720
query36 1434 1422 1288 1288
query37 159 113 95 95
query38 3244 3182 3062 3062
query39 929 915 900 900
query39_1 877 869 880 869
query40 249 175 135 135
query41 75 69 70 69
query42 115 114 113 113
query43 353 336 294 294
query44
query45 213 209 203 203
query46 1092 1210 758 758
query47 2425 2383 2327 2327
query48 409 435 300 300
query49 663 524 414 414
query50 998 350 265 265
query51 4305 4367 4302 4302
query52 108 110 98 98
query53 261 278 212 212
query54 349 306 286 286
query55 95 94 93 93
query56 336 351 315 315
query57 1451 1440 1317 1317
query58 318 279 281 279
query59 1617 1713 1471 1471
query60 344 345 331 331
query61 195 191 185 185
query62 707 673 592 592
query63 253 208 225 208
query64 2533 809 617 617
query65
query66 1736 468 348 348
query67 29929 29774 29721 29721
query68
query69 466 351 317 317
query70 1066 1001 959 959
query71 313 284 272 272
query72 3009 2744 2460 2460
query73 837 771 427 427
query74 5196 4938 4862 4862
query75 2686 2600 2273 2273
query76 2260 1144 750 750
query77 408 420 384 384
query78 12576 12516 11959 11959
query79 1484 1029 760 760
query80 720 554 475 475
query81 460 278 250 250
query82 1363 156 126 126
query83 327 276 247 247
query84 306 136 110 110
query85 902 527 450 450
query86 422 340 312 312
query87 3449 3393 3271 3271
query88 3639 2743 2730 2730
query89 456 389 343 343
query90 1932 185 184 184
query91 181 168 135 135
query92 83 78 75 75
query93 1477 1450 925 925
query94 562 362 304 304
query95 680 382 442 382
query96 1095 756 347 347
query97 2742 2778 2582 2582
query98 232 228 233 228
query99 1184 1152 1035 1035
Total cold run time: 255653 ms
Total hot run time: 173129 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4553675898
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4554543737
<details>
<summary>TPC-DS: <b>Total hot run time: 172282 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4ae57b270c3eea2a933518d7ecf88ac20d1f8b75, data reload: false
query5 4313 660 546 546
query6 339 229 207 207
query7 4224 559 304 304
query8 330 234 213 213
query9 8818 4099 4099 4099
query10 467 340 292 292
query11 5776 2804 2227 2227
query12 180 127 126 126
query13 1284 606 419 419
query14 6093 5454 5123 5123
query14_1 4528 4452 4457 4452
query15 216 200 184 184
query16 1058 485 418 418
query17 1126 720 602 602
query18 2514 490 367 367
query19 219 212 165 165
query20 141 137 135 135
query21 212 140 120 120
query22 13611 13594 13320 13320
query23 17438 16421 16232 16232
query23_1 16274 16433 16343 16343
query24 7418 1810 1307 1307
query24_1 1351 1339 1334 1334
query25 589 507 437 437
query26 1322 340 186 186
query27 2644 589 341 341
query28 4515 2006 2046 2006
query29 1059 661 531 531
query30 304 236 203 203
query31 1152 1085 960 960
query32 91 80 78 78
query33 569 373 322 322
query34 1187 1154 687 687
query35 779 797 699 699
query36 1422 1388 1226 1226
query37 156 108 97 97
query38 3190 3182 3060 3060
query39 934 915 931 915
query39_1 908 865 878 865
query40 236 152 130 130
query41 75 71 72 71
query42 114 113 113 113
query43 330 332 300 300
query44
query45 224 214 204 204
query46 1064 1214 751 751
query47 2370 2401 2286 2286
query48 420 434 302 302
query49 647 517 409 409
query50 1036 354 263 263
query51 4367 4341 4268 4268
query52 115 117 98 98
query53 260 284 204 204
query54 321 302 272 272
query55 96 94 90 90
query56 321 360 303 303
query57 1440 1427 1319 1319
query58 299 282 264 264
query59 1599 1688 1467 1467
query60 322 327 303 303
query61 161 158 149 149
query62 693 643 579 579
query63 249 200 210 200
query64 2425 795 676 676
query65
query66 1748 478 365 365
query67 29745 29721 29562 29562
query68
query69 465 347 317 317
query70 1032 994 1023 994
query71 307 280 280 280
query72 3034 2737 2350 2350
query73 863 754 429 429
query74 5127 4974 4776 4776
query75 2695 2606 2273 2273
query76 2299 1130 774 774
query77 411 409 331 331
query78 12541 12460 12025 12025
query79 1479 1061 733 733
query80 774 552 450 450
query81 479 284 246 246
query82 1378 157 128 128
query83 349 281 248 248
query84 264 142 110 110
query85 927 536 450 450
query86 456 342 345 342
query87 3432 3393 3205 3205
query88 3598 2741 2720 2720
query89 453 397 350 350
query90 1757 189 189 189
query91 182 172 143 143
query92 83 81 79 79
query93 1472 1384 807 807
query94 616 347 327 327
query95 668 397 356 356
query96 1035 781 357 357
query97 2723 2743 2598 2598
query98 243 233 226 226
query99 1185 1142 1021 1021
Total cold run time: 254605 ms
Total hot run time: 172282 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4553351562
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Add release-enabled Doris check macros [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63730:
URL: https://github.com/apache/doris/pull/63730#issuecomment-4555350140
# BE Regression && UT Coverage Report
Increment line coverage `34.15% (14/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63730_4ae57b270c3eea2a933518d7ecf88ac20d1f8b75_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63730_4ae57b270c3eea2a933518d7ecf88ac20d1f8b75_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.87% (28118/38065) |
| Line Coverage | 57.81% (305444/528381) |
| Region Coverage | 54.87% (255085/464914) |
| Branch Coverage | 56.46% (110374/195494) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org