[GitHub] [pinot] navina commented on a diff in pull request #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #11096:
URL: https://github.com/apache/pinot/pull/11096#discussion_r1262954847


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterIntegrationTest.java:
##########
@@ -271,7 +271,17 @@ public void testAddRemoveDictionaryAndInvertedIndex()
     JsonNode queryResponse = postQuery(query);
     assertEquals(queryResponse.get("totalDocs").asLong(), numTotalDocs);
     // Full table scan without dictionary
-    assertEquals(queryResponse.get("numEntriesScannedInFilter").asLong(), numTotalDocs);
+    // The offline segments are created deterministically and all the offline segments contain "ActualElapsedTime =
+    // -9999" records.
+    // The realtime segments are created non-deterministically (uses system time for Kafka partitioning) and there is

Review Comment:
   Would it be a better fix to make the data partitioning more deterministic for realtime tests? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org