You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/21 18:30:32 UTC

[GitHub] [arrow-datafusion] isidentical commented on pull request #3915: Simplify redundant predicates

isidentical commented on PR #3915:
URL: https://github.com/apache/arrow-datafusion/pull/3915#issuecomment-1287307982

   Thank you for the PR @src255, I think it looks pretty good as is (an example comparison is available inside `expr_contains`). I think all you have to do next is add some tests (a very similiar example is `test_simplify_optimized_plan`). One thing to note is, I think we might have `a AND a` already so might make sense to check if the test fails first and gets fixed with your revision. But `a OR a` should be still good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org